Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 2350773004: Move HitTestResult::isMisspelled to SelectionController (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move HitTestResult::isMisspelled to SelectionController This patch moves HitTestResult::isMisspelled to SelectionController.cpp as a static function, since it is only used by SelectionController. BUG=n/a TEST=n/a; no behavior change Committed: https://crrev.com/f146e54fab682126a7d35ce2b5a7c8b9726f7afd Cr-Commit-Position: refs/heads/master@{#419752}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove DocumentMarkerController.h from include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 2 chunks +13 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestResult.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestResult.cpp View 1 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-20 08:32:37 UTC) #6
tkent
lgtm https://codereview.chromium.org/2350773004/diff/1/third_party/WebKit/Source/core/layout/HitTestResult.cpp File third_party/WebKit/Source/core/layout/HitTestResult.cpp (right): https://codereview.chromium.org/2350773004/diff/1/third_party/WebKit/Source/core/layout/HitTestResult.cpp#newcode29 third_party/WebKit/Source/core/layout/HitTestResult.cpp:29: #include "core/editing/EditingUtilities.h" Can we remove #includes for core/editing/ ...
4 years, 3 months ago (2016-09-20 12:20:10 UTC) #7
Xiaocheng
https://codereview.chromium.org/2350773004/diff/1/third_party/WebKit/Source/core/layout/HitTestResult.cpp File third_party/WebKit/Source/core/layout/HitTestResult.cpp (right): https://codereview.chromium.org/2350773004/diff/1/third_party/WebKit/Source/core/layout/HitTestResult.cpp#newcode29 third_party/WebKit/Source/core/layout/HitTestResult.cpp:29: #include "core/editing/EditingUtilities.h" On 2016/09/20 at 12:20:10, tkent wrote: > ...
4 years, 3 months ago (2016-09-20 12:56:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350773004/20001
4 years, 3 months ago (2016-09-20 14:16:32 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 14:21:00 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 14:22:31 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f146e54fab682126a7d35ce2b5a7c8b9726f7afd
Cr-Commit-Position: refs/heads/master@{#419752}

Powered by Google App Engine
This is Rietveld 408576698