Move HitTestResult::isMisspelled to SelectionController

third_party/WebKit/Source/core/layout/HitTestResult.cpp

 /*
  * Copyright (C) 2006, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Nokia Corporation and/or its subsidiary(-ies)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
 */
 
 #include "core/layout/HitTestResult.h"
 
 #include "core/HTMLNames.h"
 #include "core/InputTypeNames.h"
 #include "core/dom/PseudoElement.h"
 #include "core/dom/shadow/FlatTreeTraversal.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/editing/EditingUtilities.h"

[tkent, 2016/09/20 12:20:10]

Can we remove #includes for core/editing/ ?

[Xiaocheng, 2016/09/20 12:56:14]

Only DocumentMarkerController.h can be removed, and has been removed in Patch 2.

 #include "core/editing/FrameSelection.h"
 #include "core/editing/markers/DocumentMarkerController.h"
 #include "core/frame/LocalFrame.h"
 #include "core/html/HTMLAreaElement.h"
 #include "core/html/HTMLImageElement.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLMapElement.h"
 #include "core/html/HTMLMediaElement.h"
 #include "core/html/HTMLTextAreaElement.h"
 #include "core/html/parser/HTMLParserIdioms.h"
@@ skipping 311 matching lines @@
     if (!m_innerURLElement)
         return KURL();
     return m_innerURLElement->hrefURL();
 }
 
 bool HitTestResult::isLiveLink() const
 {
     return m_innerURLElement && m_innerURLElement->isLiveLink();
 }
 
-// TODO(xiaochengh): We should move |HitTestResult::isMisspelled()| to
-// "SelectionController.cpp" as static function.
-bool HitTestResult::isMisspelled() const
-{
-    if (!innerNode() || !innerNode()->layoutObject())
-        return false;
-    VisiblePosition pos = createVisiblePosition(innerNode()->layoutObject()->positionForPoint(localPoint()));
-    if (pos.isNull())
-        return false;
-    return m_innerNode->document().markers().markersInRange(
-        EphemeralRange(pos.deepEquivalent().parentAnchoredEquivalent()), DocumentMarker::MisspellingMarkers()).size() > 0;
-}
-
 bool HitTestResult::isOverLink() const
 {
     return m_innerURLElement && m_innerURLElement->isLink();
 }
 
 String HitTestResult::textContent() const
 {
     if (!m_innerURLElement)
         return String();
     return m_innerURLElement->textContent();
@@ skipping 129 matching lines @@
     else if (isHTMLMapElement(m_innerNode))
         imageMapImageElement = toHTMLMapElement(m_innerNode)->imageElement();
 
     if (!imageMapImageElement)
         return m_innerNode.get();
 
     return imageMapImageElement;
 }
 
 } // namespace blink