Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2350703002:
mb: Add compile targets used by V8 trybot (Closed)
|
Created:
4 years, 3 months ago by Michael Achenbach Modified:
4 years, 3 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmb: Add compile targets used by V8 trybot
This unbreaks the V8 Chromium trybot
v8_linux_chromium_gn_rel, broken by missing target mappings
in https://codereview.chromium.org/2352473002
BUG=555273, 648153
Committed: https://crrev.com/5da3189d5d0faa56d75bd261f7d76248c40daa30
Cr-Commit-Position: refs/heads/master@{#419460}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fixing buildbot json #
Total comments: 3
Messages
Total messages: 21 (13 generated)
Description was changed from ========== mb: Add compile targets used by V8 trybot BUG= ========== to ========== mb: Add compile targets used by V8 trybot This unbreaks the V8 Chromium trybot v8_linux_chromium_gn_rel, broken by missing target mappings in https://codereview.chromium.org/2352473002 BUG=555273,648153 ==========
machenbach@chromium.org changed reviewers: + brettw@chromium.org, dpranke@chromium.org, jochen@chromium.org
PTAL. This is to fix the only chromium trybot in the V8 CQ. Currently we're lacking chromium-compile coverage. https://codereview.chromium.org/2350703002/diff/1/testing/buildbot/gn_isolate... File testing/buildbot/gn_isolate_map.pyl (right): https://codereview.chromium.org/2350703002/diff/1/testing/buildbot/gn_isolate... testing/buildbot/gn_isolate_map.pyl:708: "type": "additional_compile_target", This is probably not just an additional compile target, but this should be enough to unbreak our compile-only bot. https://codereview.chromium.org/2350703002/diff/1/testing/buildbot/gn_isolate... testing/buildbot/gn_isolate_map.pyl:714: "postmortem-metadata": { I'm wondering if some of these mappings should not live in the respective subprojects?
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Fixing presubmit in patch 2 https://codereview.chromium.org/2350703002/diff/20001/testing/buildbot/tryser... File testing/buildbot/tryserver.v8.json (right): https://codereview.chromium.org/2350703002/diff/20001/testing/buildbot/tryser... testing/buildbot/tryserver.v8.json:10: "blink_tests", This was always overridden by https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_... - but presubmit requires the tests to be listed in a chromium-side json. After this change we could probably remove the infra-side override.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== mb: Add compile targets used by V8 trybot This unbreaks the V8 Chromium trybot v8_linux_chromium_gn_rel, broken by missing target mappings in https://codereview.chromium.org/2352473002 BUG=555273,648153 ========== to ========== mb: Add compile targets used by V8 trybot This unbreaks the V8 Chromium trybot v8_linux_chromium_gn_rel, broken by missing target mappings in https://codereview.chromium.org/2352473002 BUG=555273,648153 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== mb: Add compile targets used by V8 trybot This unbreaks the V8 Chromium trybot v8_linux_chromium_gn_rel, broken by missing target mappings in https://codereview.chromium.org/2352473002 BUG=555273,648153 ========== to ========== mb: Add compile targets used by V8 trybot This unbreaks the V8 Chromium trybot v8_linux_chromium_gn_rel, broken by missing target mappings in https://codereview.chromium.org/2352473002 BUG=555273,648153 Committed: https://crrev.com/5da3189d5d0faa56d75bd261f7d76248c40daa30 Cr-Commit-Position: refs/heads/master@{#419460} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5da3189d5d0faa56d75bd261f7d76248c40daa30 Cr-Commit-Position: refs/heads/master@{#419460}
Message was sent while issue was closed.
lgtm, sorry for the breakage. https://codereview.chromium.org/2350703002/diff/20001/testing/buildbot/tryser... File testing/buildbot/tryserver.v8.json (right): https://codereview.chromium.org/2350703002/diff/20001/testing/buildbot/tryser... testing/buildbot/tryserver.v8.json:10: "blink_tests", On 2016/09/19 13:10:06, machenbach (slow) wrote: > This was always overridden by > https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_... > - but presubmit requires the tests to be listed in a chromium-side json. After > this change we could probably remove the infra-side override. overridden, or just added to? I thought the two were added together. At any rate, (a) you can get around the presubmit check by listing exceptions in manage.py, and (b) it's better if you list them here rather than infra-side anyway.
Message was sent while issue was closed.
https://codereview.chromium.org/2350703002/diff/20001/testing/buildbot/tryser... File testing/buildbot/tryserver.v8.json (right): https://codereview.chromium.org/2350703002/diff/20001/testing/buildbot/tryser... testing/buildbot/tryserver.v8.json:10: "blink_tests", On 2016/09/19 17:14:46, Dirk Pranke wrote: > On 2016/09/19 13:10:06, machenbach (slow) wrote: > > This was always overridden by > > > https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_... > > - but presubmit requires the tests to be listed in a chromium-side json. After > > this change we could probably remove the infra-side override. > > overridden, or just added to? I thought the two were added together. > > At any rate, (a) you can get around the presubmit check by listing exceptions in > manage.py, and (b) it's better if you list them here rather than infra-side > anyway. I also first thought "added". But production shows different as we only analyze and compile the infra targets. These are also the only ones we want - the outdated list on the left would have been a bug. Anyway - now it should be good and we can clean up the infra side. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
