Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2352473002: Re-land "Update MB to use `gn analyze`." (Closed)

Created:
4 years, 3 months ago by Dirk Pranke
Modified:
4 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land "Update MB to use `gn analyze`." This change re-lands r411530, with a bunch of additional targets added to gn_isolate_map.pyl to handle all of the other compile and test targets (including mappings for apk's and junit tests). TBR=brettw@chromium.org BUG=555273 Committed: https://crrev.com/cb4a2e24a10c9063718e266d94738843898a7c60 Cr-Commit-Position: refs/heads/master@{#419404}

Patch Set 1 : original patch (the version that was reverted) #

Patch Set 2 : add changes for testing purposes #

Patch Set 3 : add missing targets #

Patch Set 4 : remove testing changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+428 lines, -223 lines) Patch
M testing/buildbot/gn_isolate_map.pyl View 1 2 21 chunks +194 lines, -9 lines 0 comments Download
M testing/buildbot/manage.py View 1 2 3 chunks +83 lines, -30 lines 0 comments Download
M tools/mb/mb.py View 1 2 20 chunks +131 lines, -124 lines 0 comments Download
M tools/mb/mb_unittest.py View 2 chunks +20 lines, -60 lines 0 comments Download

Messages

Total messages: 36 (33 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352473002/130001
4 years, 3 months ago (2016-09-19 01:08:59 UTC) #32
commit-bot: I haz the power
Committed patchset #4 (id:130001)
4 years, 3 months ago (2016-09-19 01:14:15 UTC) #34
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 01:16:50 UTC) #36
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cb4a2e24a10c9063718e266d94738843898a7c60
Cr-Commit-Position: refs/heads/master@{#419404}

Powered by Google App Engine
This is Rietveld 408576698