[wasm] Set up Table and Memory constructors

[wasm] Set up Table and Memory constructors

Set up Wasm Table and Memory constructors

This only provides skeletons so far: the constructors work, but the
types are not wired up with the import/export mechanism yet; methods are
still nops.

Also, fix errors generated from Wasm to be proper Error/TypeError
instances instead of just strings.

I took over this CL from rossberg@chromium.org. The original CL is
https://codereview.chromium.org/2342623002

R=titzer@chromium.org, rossberg@chromium.org

Committed: https://crrev.com/698bbe418aaab8c7e41090eab9400440ce7a498f
Cr-Commit-Position: refs/heads/master@{#39588}

[ahaas, 2016-09-19 14:01:48]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 14:01:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 15:03:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 15:03:05]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[titzer, 2016-09-20 12:37:21]

lgtm with comment

https://codereview.chromium.org/2350643003/diff/1/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/2350643003/diff/1/src/wasm/wasm-js.cc#newcode342
src/wasm/wasm-js.cc:342: int64_t number;
Can we factor out a helper routine for setting a numeric property on an object?
Basically the int64_t / IntegerValue / positive check here and below? If you
make it take an expected range (i.e. minimum legal value, maximum legal value),
then you can use it below, too.

https://codereview.chromium.org/2350643003/diff/1/src/wasm/wasm-js.cc#newcode590
src/wasm/wasm-js.cc:590: Handle<JSFunction> module_constructor =
It's tough to see what's going in here exactly, but is it possible to factor out
a subroutine that creates the constructor and the prototype and the map
together?

[ahaas, 2016-09-21 09:37:44]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 09:37:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-09-21 09:38:10]

ahaas@chromium.org changed reviewers:
+ gdeepti@chromium.org

[ahaas, 2016-09-21 09:38:11]

Ben, PTAL

https://codereview.chromium.org/2350643003/diff/1/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/2350643003/diff/1/src/wasm/wasm-js.cc#newcode342
src/wasm/wasm-js.cc:342: int64_t number;
On 2016/09/20 at 12:37:21, titzer wrote:
> Can we factor out a helper routine for setting a numeric property on an
object? Basically the int64_t / IntegerValue / positive check here and below? If
you make it take an expected range (i.e. minimum legal value, maximum legal
value), then you can use it below, too.

Done.

https://codereview.chromium.org/2350643003/diff/1/src/wasm/wasm-js.cc#newcode590
src/wasm/wasm-js.cc:590: Handle<JSFunction> module_constructor =
On 2016/09/20 at 12:37:21, titzer wrote:
> It's tough to see what's going in here exactly, but is it possible to factor
out a subroutine that creates the constructor and the prototype and the map
together?

I restructured code now, but I don't think that it's worth factoring out
subroutines. Especially functions like
context->set_wasm_module_constructor(*module_constructor); and
context->set_wasm_instance_constructor(*instance_constructor);
are problematic.

[titzer, 2016-09-21 09:47:44]

lgtm

https://codereview.chromium.org/2350643003/diff/1/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/2350643003/diff/1/src/wasm/wasm-js.cc#newcode590
src/wasm/wasm-js.cc:590: Handle<JSFunction> module_constructor =
On 2016/09/21 09:38:11, ahaas wrote:
> On 2016/09/20 at 12:37:21, titzer wrote:
> > It's tough to see what's going in here exactly, but is it possible to factor
> out a subroutine that creates the constructor and the prototype and the map
> together?
> 
> I restructured code now, but I don't think that it's worth factoring out
> subroutines. Especially functions like
> context->set_wasm_module_constructor(*module_constructor); and
> context->set_wasm_instance_constructor(*instance_constructor);
> are problematic.

Ok, we can always take another crack at it later.

[commit-bot: I haz the power, 2016-09-21 10:09:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 10:09:54]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-09-21 10:33:11]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-09-21 10:33:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 10:40:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-21 10:40:41]

Description was changed from

==========
[wasm] Set up Table and Memory constructors

Set up Wasm Table and Memory constructors

This only provides skeletons so far: the constructors work, but the
types are not wired up with the import/export mechanism yet; methods are
still nops.

Also, fix errors generated from Wasm to be proper Error/TypeError
instances instead of just strings.

I took over this CL from rossberg@chromium.org. The original CL is
https://codereview.chromium.org/2342623002


R=titzer@chromium.org, rossberg@chromium.org
==========

to

==========
[wasm] Set up Table and Memory constructors

Set up Wasm Table and Memory constructors

This only provides skeletons so far: the constructors work, but the
types are not wired up with the import/export mechanism yet; methods are
still nops.

Also, fix errors generated from Wasm to be proper Error/TypeError
instances instead of just strings.

I took over this CL from rossberg@chromium.org. The original CL is
https://codereview.chromium.org/2342623002

R=titzer@chromium.org, rossberg@chromium.org

Committed: https://crrev.com/698bbe418aaab8c7e41090eab9400440ce7a498f
Cr-Commit-Position: refs/heads/master@{#39588}
==========

[commit-bot: I haz the power, 2016-09-21 10:40:42]

Patchset 2 (id:??) landed as
https://crrev.com/698bbe418aaab8c7e41090eab9400440ce7a498f
Cr-Commit-Position: refs/heads/master@{#39588}