[wasm] Set up Table and Memory constructors

Set up Wasm Table and Memory constructors

This only provides skeletons so far: the constructors work, but the types are not wired up with the import/export mechanism yet; methods are still nops.

Also, fix errors generated from Wasm to be proper Error/TypeError instances instead of just strings.

[rossberg, 2016-09-14 16:33:33]

Description was changed from

==========
Set up Wasm Table and Memory constructors

BUG=
==========

to

==========
Set up Wasm Table and Memory constructors

This only provides skeletons so far: the constructors work, but the types are
not wired up with the import/export mechanism yet; methods are still nops.

Also, fix errors generated from Wasm to be proper Error/TypeError instances
instead of just strings.
==========

[rossberg, 2016-09-14 16:33:33]

rossberg@chromium.org changed reviewers:
+ ahaas@chromium.org, titzer@chromium.org

[ahaas, 2016-09-15 14:41:07]

https://codereview.chromium.org/2342623002/diff/40001/src/wasm/wasm-result.h
File src/wasm/wasm-result.h (right):

https://codereview.chromium.org/2342623002/diff/40001/src/wasm/wasm-result.h#...
src/wasm/wasm-result.h:102: ErrorThrower(Isolate* isolate, const char* context)
Why does the constructor not use i::Isolate* isolate as a parameter instead of
Isolate* isolate?

https://codereview.chromium.org/2342623002/diff/40001/src/wasm/wasm-result.h#...
src/wasm/wasm-result.h:118: auto result = exception_;
Could you not use auto here please?

https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/memor...
File test/mjsunit/wasm/memory.js (right):

https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/memor...
test/mjsunit/wasm/memory.js:22: assertThrows(() => new
WebAssembly.Memory({initial: 1e20}), RangeError);
could you store 1e20 in an outOfUint32RangeValue constant and use that constant
here? Same below and in table.js

https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/memor...
test/mjsunit/wasm/memory.js:28: let memory = new WebAssembly.Memory({initial:
1});
Can you add a test where the maximum is set, e.g. new
WebAssembly.Memory({initial: 1, maximum: 10})?

https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/memor...
test/mjsunit/wasm/memory.js:30: assertSame(WebAssembly.Memory,
memory.constructor);
Can you check the value of maximum here?

https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/table.js
File test/mjsunit/wasm/table.js (right):

https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/table...
test/mjsunit/wasm/table.js:38: assertSame(WebAssembly.Table, table.constructor);
Could you add a test for the maximum property?

[ahaas, 2016-09-19 13:41:48]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 13:41:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 13:43:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 13:43:28]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/12977)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[ahaas, 2016-09-19 14:02:37]

I took over this CL in https://codereview.chromium.org/2350643003

https://codereview.chromium.org/2342623002/diff/40001/src/wasm/wasm-result.h
File src/wasm/wasm-result.h (right):

https://codereview.chromium.org/2342623002/diff/40001/src/wasm/wasm-result.h#...
src/wasm/wasm-result.h:102: ErrorThrower(Isolate* isolate, const char* context)
On 2016/09/15 at 14:41:06, ahaas wrote:
> Why does the constructor not use i::Isolate* isolate as a parameter instead of
Isolate* isolate?

I changed it to i::Isolate*

https://codereview.chromium.org/2342623002/diff/40001/src/wasm/wasm-result.h#...
src/wasm/wasm-result.h:118: auto result = exception_;
On 2016/09/15 at 14:41:06, ahaas wrote:
> Could you not use auto here please?

Done.

https://codereview.chromium.org/2342623002/diff/40001/src/wasm/wasm-result.h#...
src/wasm/wasm-result.h:118: auto result = exception_;
On 2016/09/15 at 14:41:06, ahaas wrote:
> Could you not use auto here please?

Done.

https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/memor...
File test/mjsunit/wasm/memory.js (right):

https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/memor...
test/mjsunit/wasm/memory.js:22: assertThrows(() => new
WebAssembly.Memory({initial: 1e20}), RangeError);
On 2016/09/15 at 14:41:07, ahaas wrote:
> could you store 1e20 in an outOfUint32RangeValue constant and use that
constant here? Same below and in table.js

Done.

https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/memor...
test/mjsunit/wasm/memory.js:28: let memory = new WebAssembly.Memory({initial:
1});
On 2016/09/15 at 14:41:06, ahaas wrote:
> Can you add a test where the maximum is set, e.g. new
WebAssembly.Memory({initial: 1, maximum: 10})?

Done.

https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/memor...
test/mjsunit/wasm/memory.js:30: assertSame(WebAssembly.Memory,
memory.constructor);
On 2016/09/15 at 14:41:06, ahaas wrote:
> Can you check the value of maximum here?

oh, that's not possible.

https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/table.js
File test/mjsunit/wasm/table.js (right):

https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/table...
test/mjsunit/wasm/table.js:38: assertSame(WebAssembly.Table, table.constructor);
On 2016/09/15 at 14:41:07, ahaas wrote:
> Could you add a test for the maximum property?

Done.

[titzer, 2016-09-29 13:10:38]

On 2016/09/19 14:02:37, ahaas wrote:
> I took over this CL in https://codereview.chromium.org/2350643003
> 
> https://codereview.chromium.org/2342623002/diff/40001/src/wasm/wasm-result.h
> File src/wasm/wasm-result.h (right):
> 
>
https://codereview.chromium.org/2342623002/diff/40001/src/wasm/wasm-result.h#...
> src/wasm/wasm-result.h:102: ErrorThrower(Isolate* isolate, const char*
context)
> On 2016/09/15 at 14:41:06, ahaas wrote:
> > Why does the constructor not use i::Isolate* isolate as a parameter instead
of
> Isolate* isolate?
> 
> I changed it to i::Isolate*
> 
>
https://codereview.chromium.org/2342623002/diff/40001/src/wasm/wasm-result.h#...
> src/wasm/wasm-result.h:118: auto result = exception_;
> On 2016/09/15 at 14:41:06, ahaas wrote:
> > Could you not use auto here please?
> 
> Done.
> 
>
https://codereview.chromium.org/2342623002/diff/40001/src/wasm/wasm-result.h#...
> src/wasm/wasm-result.h:118: auto result = exception_;
> On 2016/09/15 at 14:41:06, ahaas wrote:
> > Could you not use auto here please?
> 
> Done.
> 
>
https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/memor...
> File test/mjsunit/wasm/memory.js (right):
> 
>
https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/memor...
> test/mjsunit/wasm/memory.js:22: assertThrows(() => new
> WebAssembly.Memory({initial: 1e20}), RangeError);
> On 2016/09/15 at 14:41:07, ahaas wrote:
> > could you store 1e20 in an outOfUint32RangeValue constant and use that
> constant here? Same below and in table.js
> 
> Done.
> 
>
https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/memor...
> test/mjsunit/wasm/memory.js:28: let memory = new WebAssembly.Memory({initial:
> 1});
> On 2016/09/15 at 14:41:06, ahaas wrote:
> > Can you add a test where the maximum is set, e.g. new
> WebAssembly.Memory({initial: 1, maximum: 10})?
> 
> Done.
> 
>
https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/memor...
> test/mjsunit/wasm/memory.js:30: assertSame(WebAssembly.Memory,
> memory.constructor);
> On 2016/09/15 at 14:41:06, ahaas wrote:
> > Can you check the value of maximum here?
> 
> oh, that's not possible.
> 
>
https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/table.js
> File test/mjsunit/wasm/table.js (right):
> 
>
https://codereview.chromium.org/2342623002/diff/40001/test/mjsunit/wasm/table...
> test/mjsunit/wasm/table.js:38: assertSame(WebAssembly.Table,
table.constructor);
> On 2016/09/15 at 14:41:07, ahaas wrote:
> > Could you add a test for the maximum property?
> 
> Done.

ahaas has landed this, so, removing myself as a reviewer.

[titzer, 2016-09-29 13:10:48]

titzer@chromium.org changed reviewers:
- ahaas@chromium.org, titzer@chromium.org