Add Dart_GetStickyError

Add Dart_GetStickyError

- [x] Add Dart_GetStickyError.
- [x] Change Dart_SetStickyError to allow for null and also not set the pause on exit bit.

BUG=
R=turnidge@google.com

Committed: https://github.com/dart-lang/sdk/commit/632c76942cffeba06a381e8f973d61e7ca3aba1a

[Cutch, 2016-09-19 20:24:25]

Description was changed from

==========
Add Dart_GetAndClearStickyError

BUG=
==========

to

==========
Add Dart_GetStickyError

- [x] Add Dart_GetStickyError.
- [x] Change Dart_SetStickyError to allow for null and also not set the pause on
exit bit.

BUG=
==========

[Cutch, 2016-09-19 20:24:26]

johnmccutchan@google.com changed reviewers:
+ turnidge@google.com

[turnidge, 2016-09-19 20:29:46]

lgtm

[Cutch, 2016-09-19 20:31:18]

Description was changed from

==========
Add Dart_GetStickyError

- [x] Add Dart_GetStickyError.
- [x] Change Dart_SetStickyError to allow for null and also not set the pause on
exit bit.

BUG=
==========

to

==========
Add Dart_GetStickyError

- [x] Add Dart_GetStickyError.
- [x] Change Dart_SetStickyError to allow for null and also not set the pause on
exit bit.

BUG=
R=turnidge@google.com

Committed:
https://github.com/dart-lang/sdk/commit/632c76942cffeba06a381e8f973d61e7ca3aba1a
==========

[Cutch, 2016-09-19 20:31:20]

Committed patchset #2 (id:20001) manually as
632c76942cffeba06a381e8f973d61e7ca3aba1a (presubmit successful).

[siva, 2016-09-22 19:43:54]

asiva@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-09-22 19:43:55]

DBC

https://codereview.chromium.org/2350633003/diff/20001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/2350633003/diff/20001/runtime/include/dart_ap...
runtime/include/dart_api.h:1202: DART_EXPORT Dart_Handle Dart_GetStickyError();
Do we need both Dart_HasStickyError and Dart_GetStickyError?
Can't we infer from a non null return on Dart_GetStickyError that the isolate
has a sticky error?

https://codereview.chromium.org/2350633003/diff/20001/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/2350633003/diff/20001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:1492: CHECK_ISOLATE(I);
Other places we use the pattern
  Thread* T = Thread::Current();
  Isolate* I = T->isolate();
  CHECK_ISOLATE(I);
  .....
Then T is available to use inside the function instead of Thread::Current();

https://codereview.chromium.org/2350633003/diff/20001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:1494: if (I->sticky_error() != Object::null()) {
if (I->sticky_error() != Error::null()) {

https://codereview.chromium.org/2350633003/diff/20001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:1496: Api::NewHandle(Thread::Current(),
I->sticky_error());
NewHandle(T, ...);

[Cutch, 2016-09-22 19:52:14]

On 2016/09/22 19:43:55, siva wrote:
> DBC
> 
>
https://codereview.chromium.org/2350633003/diff/20001/runtime/include/dart_api.h
> File runtime/include/dart_api.h (right):
> 
>
https://codereview.chromium.org/2350633003/diff/20001/runtime/include/dart_ap...
> runtime/include/dart_api.h:1202: DART_EXPORT Dart_Handle
Dart_GetStickyError();
> Do we need both Dart_HasStickyError and Dart_GetStickyError?
> Can't we infer from a non null return on Dart_GetStickyError that the isolate
> has a sticky error?
> 
>
https://codereview.chromium.org/2350633003/diff/20001/runtime/vm/dart_api_imp...
> File runtime/vm/dart_api_impl.cc (right):
> 
>
https://codereview.chromium.org/2350633003/diff/20001/runtime/vm/dart_api_imp...
> runtime/vm/dart_api_impl.cc:1492: CHECK_ISOLATE(I);
> Other places we use the pattern
>   Thread* T = Thread::Current();
>   Isolate* I = T->isolate();
>   CHECK_ISOLATE(I);
>   .....
> Then T is available to use inside the function instead of Thread::Current();
> 
>
https://codereview.chromium.org/2350633003/diff/20001/runtime/vm/dart_api_imp...
> runtime/vm/dart_api_impl.cc:1494: if (I->sticky_error() != Object::null()) {
> if (I->sticky_error() != Error::null()) {
> 
>
https://codereview.chromium.org/2350633003/diff/20001/runtime/vm/dart_api_imp...
> runtime/vm/dart_api_impl.cc:1496: Api::NewHandle(Thread::Current(),
> I->sticky_error());
> NewHandle(T, ...);

Addressed in https://codereview.chromium.org/2359283002