Issue 2359283002: Address Siva's DBCs on https://codereview.chromium.org/2350633003/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2359283002: Address Siva's DBCs on https://codereview.chromium.org/2350633003/ (Closed)

Created:
4 years, 2 months ago by Cutch

Modified:
4 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	runtime/vm/dart_api_impl.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download

Total messages: 6 (3 generated)

Cutch

4 years, 2 months ago (2016-09-22 20:27:47 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
decac71b704e012aa98fc877682c916d80345acd (presubmit successful).