Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 23506031: Fix a test launcher hang when no tests are run. (Closed)

Created:
7 years, 3 months ago by Paweł Hajdan Jr.
Modified:
7 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Fix a test launcher hang when no tests are run. BUG=285051 R=kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221228

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M base/test/parallel_test_launcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/test/test_launcher.cc View 3 chunks +20 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
7 years, 3 months ago (2013-09-04 17:56:30 UTC) #1
Ken Russell (switch to Gerrit)
LGTM https://codereview.chromium.org/23506031/diff/1/base/test/test_launcher.cc File base/test/test_launcher.cc (right): https://codereview.chromium.org/23506031/diff/1/base/test/test_launcher.cc#newcode237 base/test/test_launcher.cc:237: fprintf(stdout, "0 tests run\n"); Did you mean to ...
7 years, 3 months ago (2013-09-04 18:00:29 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/23506031/diff/1/base/test/test_launcher.cc File base/test/test_launcher.cc (right): https://codereview.chromium.org/23506031/diff/1/base/test/test_launcher.cc#newcode237 base/test/test_launcher.cc:237: fprintf(stdout, "0 tests run\n"); On 2013/09/04 18:00:30, Ken Russell ...
7 years, 3 months ago (2013-09-04 18:02:30 UTC) #3
Ken Russell (switch to Gerrit)
BTW, is there a test for this test launcher bug? :)
7 years, 3 months ago (2013-09-04 18:07:02 UTC) #4
Paweł Hajdan Jr.
7 years, 3 months ago (2013-09-04 18:17:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r221228 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698