base/test/parallel_test_launcher.cc - Issue 23506031: Fix a test launcher hang when no tests are run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/parallel_test_launcher.cc

Issue 23506031: Fix a test launcher hang when no tests are run. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/test/parallel_test_launcher.cc

diff --git a/base/test/parallel_test_launcher.cc b/base/test/parallel_test_launcher.cc

index 4522394302ffd573c34db08da83b334e0757106e..c01a78371250beb86fdb4301485943e621beb1a2 100644

--- a/base/test/parallel_test_launcher.cc

+++ b/base/test/parallel_test_launcher.cc

@@ -134,6 +134,8 @@ ParallelTestLauncher::ParallelTestLauncher(size_t jobs)

ParallelTestLauncher::~ParallelTestLauncher() {

DCHECK(thread_checker_.CalledOnValidThread());

+ worker_pool_->Shutdown();

}

void ParallelTestLauncher::LaunchChildGTestProcess(

« no previous file with comments | « no previous file | base/test/test_launcher.cc » ('j') | base/test/test_launcher.cc » ('J')