Require confirmation for writable directory access.

chrome/common/extensions/permissions/api_permission_set.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/permissions/api_permission_set.h"
 
 #include "base/logging.h"
+#include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/values.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
 #include "chrome/common/extensions/permissions/permissions_info.h"
 #include "extensions/common/error_utils.h"
 
 namespace errors = extension_manifest_errors;
 
 namespace {
 
@@ skipping 310 matching lines @@
       continue;
     }
 
     if (!CreateAPIPermission(permission_str, permission_value, source,
                              api_permissions, error, unhandled_permissions))
       return false;
   }
   return true;
 }
 
+void APIPermissionSet::AddImpliedPermissions() {
+  // The fileSystem.write and fileSystem.directory permissions imply
+  // fileSystem.writeDirectory.
+  if (ContainsKey(map_, APIPermission::kFileSystemWrite) &&
+      ContainsKey(map_, APIPermission::kFileSystemDirectory)) {
+    insert(APIPermission::kFileSystemWriteDirectory);

[not at google - send to devlin, 2013/09/03 17:07:04]

Ugh so busted. But I agree that there doesn't seem to be a better way to do this
in our current permission warning infrastructure.

But please file a specific bug to remove this + the similar code in
permission_set.cc and set that general permission bug as blocking it. This code
is going to block the extensions refactor.

[Sam McNally, 2013/09/04 00:21:30]

Done.

+  }
+}
+
 }  // namespace extensions