Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Unified Diff: public/web/WebFrameClient.h

Issue 23506013: Make the embedder responsible for creating the WebFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: wordmith a comment Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/web/WebFrameClient.h
diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h
index b24af8068d4a2fcc803ffae5d7c3c4e7a3fd3fe7..156afd1566a15924176dd93a84c472582ee64391 100644
--- a/public/web/WebFrameClient.h
+++ b/public/web/WebFrameClient.h
@@ -110,7 +110,11 @@ public:
virtual void didAccessInitialDocument(WebFrame*) { }
// A child frame was created in this frame. This is called when the frame
- // is created and initialized.
+ // is created and initialized. Takes the name of the new frame, the parent
+ // frame and returns a new WebFrame. The WebFrame is valid until
+ // frameDetached() is called on it.
darin (slow to review) 2013/09/19 22:36:19 Isn't the WebFrame valid until the embedder calls
awong 2013/09/20 00:36:24 Hmm...would "in-use" be a better term? I'm trying
+ virtual WebFrame* createChildFrame(WebFrame* parent, const WebString& frameName) { return 0; }
+ // FIXME: Remove when all embedders use createChildFrame().
virtual void didCreateFrame(WebFrame* parent, WebFrame* child) { }
// This frame set its opener to null, disowning it.
« public/web/WebFrame.h ('K') | « public/web/WebFrame.h ('k') | public/web/WebView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698