Make the embedder responsible for creating the WebFrame

public/web/WebFrameClient.h

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 92 matching lines @@
 
 
     // General notifications -----------------------------------------------
 
     // Indicates that another page has accessed the DOM of the initial empty
     // document of a main frame. After this, it is no longer safe to show a
     // pending navigation's URL, because a URL spoof is possible.
     virtual void didAccessInitialDocument(WebFrame*) { }
 
     // A child frame was created in this frame. This is called when the frame
-    // is created and initialized.
+    // is created and initialized. Takes the name of the new frame, the parent
+    // frame and returns a new WebFrame. The WebFrame is valid until
+    // frameDetached() is called on it.

[darin (slow to review), 2013/09/19 22:36:19]

Isn't the WebFrame valid until the embedder calls close() on it?

[awong, 2013/09/20 00:36:24]

Hmm...would "in-use" be a better term?

I'm trying to say that the client implementer should expect the returned
WebFrame can be deleted when frameDetached() is called.

+    virtual WebFrame* createChildFrame(WebFrame* parent, const WebString& frameName) { return 0; }
+    // FIXME: Remove when all embedders use createChildFrame().
     virtual void didCreateFrame(WebFrame* parent, WebFrame* child) { }
 
     // This frame set its opener to null, disowning it.
     // See http://html.spec.whatwg.org/#dom-opener.
     virtual void didDisownOpener(WebFrame*) { }
 
     // This frame has been detached from the view, but has not been closed yet.
     virtual void frameDetached(WebFrame*) { }
 
     // This frame is about to be closed. This is called after frameDetached,
@@ skipping 240 matching lines @@
     // Extensions3D.h in WebCore/platform/graphics).
     virtual void didLoseWebGLContext(WebFrame*, int) { }
 
 protected:
     ~WebFrameClient() { }
 };
 
 } // namespace WebKit
 
 #endif