Chromium Code Reviews| Index: public/web/WebFrameClient.h |
| diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h |
| index b24af8068d4a2fcc803ffae5d7c3c4e7a3fd3fe7..156afd1566a15924176dd93a84c472582ee64391 100644 |
| --- a/public/web/WebFrameClient.h |
| +++ b/public/web/WebFrameClient.h |
| @@ -110,7 +110,11 @@ public: |
| virtual void didAccessInitialDocument(WebFrame*) { } |
| // A child frame was created in this frame. This is called when the frame |
| - // is created and initialized. |
| + // is created and initialized. Takes the name of the new frame, the parent |
| + // frame and returns a new WebFrame. The WebFrame is valid until |
| + // frameDetached() is called on it. |
|
darin (slow to review)
2013/09/19 22:36:19
Isn't the WebFrame valid until the embedder calls
awong
2013/09/20 00:36:24
Hmm...would "in-use" be a better term?
I'm trying
|
| + virtual WebFrame* createChildFrame(WebFrame* parent, const WebString& frameName) { return 0; } |
| + // FIXME: Remove when all embedders use createChildFrame(). |
| virtual void didCreateFrame(WebFrame* parent, WebFrame* child) { } |
| // This frame set its opener to null, disowning it. |