Fix gamepad connected status on Android

Fix gamepad connected status on Android

Commit 667f05771b5c1275f87599076d222c0ed21ba22b created a regression
in gamepad API functionality on Android by removing the assignment
that sets the gamepad.connected value. This CL adds the missing
assignment back.

BUG=644162
Committed: https://crrev.com/4b5f513335e161aa156e0114b052e18a96e44871
Cr-Commit-Position: refs/heads/master@{#422947}

[cgutman, 2016-09-18 00:07:13]

Description was changed from

==========
Fix gamepad connected status on Android

Commit 667f05771b5c1275f87599076d222c0ed21ba22b created a regression
in gamepad API functionality on Android by removing the assignment
that sets the gamepad.connected value. This CL adds the missing
assignment back.

BUG=644162
==========

to

==========
Fix gamepad connected status on Android

Commit 667f05771b5c1275f87599076d222c0ed21ba22b created a regression
in gamepad API functionality on Android by removing the assignment
that sets the gamepad.connected value. This CL adds the missing
assignment back.

BUG=644162
==========

[cgutman, 2016-09-18 00:07:13]

aicommander@gmail.com changed reviewers:
+ aelias@chromium.org, bajones@chromium.org

[cgutman, 2016-09-18 00:11:35]

This fixes an Android gamepad regression introduced by some
refactoring in r411375.

This (or another fix for this bug) needs to be merged into
the Chrome 54 Beta branch too. I'm not sure what the
procedure is for doing that.

[aelias_OOO_until_Jul13, 2016-09-18 03:17:16]

On 2016/09/18 at 00:11:35, aicommander wrote:
> This fixes an Android gamepad regression introduced by some
> refactoring in r411375.
> 
> This (or another fix for this bug) needs to be merged into
> the Chrome 54 Beta branch too. I'm not sure what the
> procedure is for doing that.

I can take care of the merge to 54 if needed.  In the meantime, would it be
possible to include in this patch a unit test that would've caught this bug?

[aelias_OOO_until_Jul13, 2016-09-18 03:45:14]

> In the meantime, would it be possible to include in this patch a unit test
that would've caught this bug?

Well, it's not immediately obvious to me how and it seems like Android-specific
unit test crasher http://crbug.com/147549 might make this difficult.  It's not
your responsibility to write a unit test for a regression introduced by someone
else, so you can feel free to bajones@ take care of the unit test.  (I'd rather
we didn't land a fix without one, though.  There's still several weeks before 54
gets to stable channel.)

[aelias_OOO_until_Jul13, 2016-10-04 19:55:18]

aelias@chromium.org changed reviewers:
+ scottmg@chromium.org
- bajones@chromium.org

[aelias_OOO_until_Jul13, 2016-10-04 19:55:48]

Let's just land this as is and cherry-pick to M54 since bajones@ is on leave. 
lgtm, adding scottmg@ for OWNERS.

[scottmg, 2016-10-04 20:07:02]

lgtm

[aelias_OOO_until_Jul13, 2016-10-04 20:43:18]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2016-10-04 20:44:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 21:48:34]

Description was changed from

==========
Fix gamepad connected status on Android

Commit 667f05771b5c1275f87599076d222c0ed21ba22b created a regression
in gamepad API functionality on Android by removing the assignment
that sets the gamepad.connected value. This CL adds the missing
assignment back.

BUG=644162
==========

to

==========
Fix gamepad connected status on Android

Commit 667f05771b5c1275f87599076d222c0ed21ba22b created a regression
in gamepad API functionality on Android by removing the assignment
that sets the gamepad.connected value. This CL adds the missing
assignment back.

BUG=644162
==========

[commit-bot: I haz the power, 2016-10-04 21:48:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-04 21:52:15]

Description was changed from

==========
Fix gamepad connected status on Android

Commit 667f05771b5c1275f87599076d222c0ed21ba22b created a regression
in gamepad API functionality on Android by removing the assignment
that sets the gamepad.connected value. This CL adds the missing
assignment back.

BUG=644162
==========

to

==========
Fix gamepad connected status on Android

Commit 667f05771b5c1275f87599076d222c0ed21ba22b created a regression
in gamepad API functionality on Android by removing the assignment
that sets the gamepad.connected value. This CL adds the missing
assignment back.

BUG=644162

Committed: https://crrev.com/4b5f513335e161aa156e0114b052e18a96e44871
Cr-Commit-Position: refs/heads/master@{#422947}
==========

[commit-bot: I haz the power, 2016-10-04 21:52:16]

Patchset 1 (id:??) landed as
https://crrev.com/4b5f513335e161aa156e0114b052e18a96e44871
Cr-Commit-Position: refs/heads/master@{#422947}