Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: components/error_page_strings.grdp

Issue 2350483002: Improve error pages on client certificate failures. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/error_page/common/localized_error.cc ('k') | net/socket/ssl_client_socket_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/error_page_strings.grdp
diff --git a/components/error_page_strings.grdp b/components/error_page_strings.grdp
index c732fab8dd94cd7283c18e34c11cd0efb4d22aba..7c2e4e479d325290fcb73efeb80b22d352aea1ab 100644
--- a/components/error_page_strings.grdp
+++ b/components/error_page_strings.grdp
@@ -255,7 +255,7 @@
This site can’t provide a secure connection
</message>
<message name="IDS_ERRORPAGES_SUMMARY_BAD_SSL_CLIENT_AUTH_CERT" desc="Summary in the error page for SSL client certificate authentication failure.">
- <ph name="HOST_NAME">&lt;strong jscontent="hostName"&gt;&lt;/strong&gt;<ex>www.whatever.com</ex></ph> didn’t accept your login certificate, or your login certificate may have expired.
+ <ph name="HOST_NAME">&lt;strong jscontent="hostName"&gt;&lt;/strong&gt;<ex>www.whatever.com</ex></ph> requested a login certificate. It may not have been provided or your login certificate may have expired or be invalid.
davidben 2016/09/16 22:06:13 Hrm. Probably should do "It" => "One"?
svaldez 2016/09/19 20:43:15 Maybe "One may not have been provided or your logi
davidben 2016/09/19 21:28:07 Done.
</message>
<message name="IDS_ERRORPAGES_SUMMARY_BLOCKED_BY_EXTENSION" desc="Summary in the error page when an extension blocks a request.">
Requests to the server have been blocked by an extension.
@@ -333,6 +333,9 @@
<message name="IDS_ERRORPAGES_SUGGESTION_GOOGLE_SEARCH_SUMMARY" desc="When a page fails to load, sometimes we suggest a specific Google search.">
Search Google for <ph name="LINK">&lt;a jsvalues="href:searchUrl;.jstdata:$this" onclick="linkClicked(this.jstdata)" jscontent="searchTerms" id="search-link"&gt;<ex>Example search terms</ex>&lt;/a&gt;</ph>
</message>
+ <message name="IDS_ERRORPAGES_SUGGESTION_CLIENT_CERTIFICATE" desc="The message displayed in a list of suggestions following a network error suggesting to the user to reload with a valid client certificate. The suggestions list is prefixed with 'Try:'.">
davidben 2016/09/16 22:06:13 I used CLIENT instead of LOGIN in the code to be c
+ Reloading with a valid login certificate
+ </message>
<if expr="is_macosx">
<message name="IDS_ERRORPAGES_SUGGESTION_DIAGNOSE" desc="Label for the link that invokes the connection diagnostic tool on the error page displayed in a list of suggestions. The suggestions list is prefixed with 'Try:'.">
<ph name="BEGIN_LINK">&lt;a href="javascript:diagnoseErrors()" id="diagnose-link"&gt;</ph>Running Network Diagnostics<ph name="END_LINK">&lt;/a&gt;</ph>
« no previous file with comments | « components/error_page/common/localized_error.cc ('k') | net/socket/ssl_client_socket_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698