Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Unified Diff: components/error_page/common/localized_error.cc

Issue 2350483002: Improve error pages on client certificate failures. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/error_page_strings.grdp » ('j') | components/error_page_strings.grdp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/error_page/common/localized_error.cc
diff --git a/components/error_page/common/localized_error.cc b/components/error_page/common/localized_error.cc
index 1f6fffe697036b7980482d36903a7bcf79e7e76a..2973a2281e9e730a70dba9e38a9f7cdea68bb01c 100644
--- a/components/error_page/common/localized_error.cc
+++ b/components/error_page/common/localized_error.cc
@@ -65,6 +65,7 @@ enum NAV_SUGGESTIONS {
SUGGEST_COMPLETE_SETUP = 1 << 11,
// Reload page suggestion for pages created by a post.
SUGGEST_REPOST_RELOAD = 1 << 12,
+ SUGGEST_CLIENT_CERTIFICATE = 1 << 13,
};
enum SHOW_BUTTONS {
@@ -242,8 +243,8 @@ const LocalizedErrorMap net_error_options[] = {
{net::ERR_BAD_SSL_CLIENT_AUTH_CERT,
IDS_ERRORPAGES_HEADING_INSECURE_CONNECTION,
IDS_ERRORPAGES_SUMMARY_BAD_SSL_CLIENT_AUTH_CERT,
- SUGGEST_CONTACT_ADMINISTRATOR,
- SHOW_NO_BUTTONS,
+ SUGGEST_CONTACT_ADMINISTRATOR | SUGGEST_CLIENT_CERTIFICATE,
+ SHOW_BUTTON_RELOAD,
},
{net::ERR_SSL_WEAK_SERVER_EPHEMERAL_DH_KEY,
IDS_ERRORPAGES_HEADING_INSECURE_CONNECTION,
@@ -645,6 +646,12 @@ void GetSuggestionsSummaryList(int error_code,
IDS_ERRORPAGES_SUGGESTION_CHECK_CONNECTION_SUMMARY, false);
}
+ if (suggestions & SUGGEST_CLIENT_CERTIFICATE) {
+ AddSingleEntryDictionaryToList(suggestions_summary_list, "summary",
+ IDS_ERRORPAGES_SUGGESTION_CLIENT_CERTIFICATE,
+ false);
+ }
+
#if !defined(OS_ANDROID) && !defined(OS_IOS)
if (IsSuggested(suggestions, SUGGEST_DNS_CONFIG) &&
IsSuggested(suggestions, SUGGEST_FIREWALL_CONFIG) &&
« no previous file with comments | « no previous file | components/error_page_strings.grdp » ('j') | components/error_page_strings.grdp » ('J')

Powered by Google App Engine
This is Rietveld 408576698