Improve error pages on client certificate failures.

components/error_page/common/localized_error.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/error_page/common/localized_error.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 47 matching lines @@
   SUGGEST_PROXY_CONFIG                      = 1 << 4,
   SUGGEST_DISABLE_EXTENSION                 = 1 << 5,
   SUGGEST_LEARNMORE                         = 1 << 6,
   SUGGEST_CONTACT_ADMINISTRATOR             = 1 << 7,
   SUGGEST_UNSUPPORTED_CIPHER                = 1 << 8,
   SUGGEST_ANTIVIRUS_CONFIG                  = 1 << 9,
   SUGGEST_OFFLINE_CHECKS                    = 1 << 10,
   SUGGEST_COMPLETE_SETUP                    = 1 << 11,
   // Reload page suggestion for pages created by a post.
   SUGGEST_REPOST_RELOAD                     = 1 << 12,
+  SUGGEST_CLIENT_CERTIFICATE                = 1 << 13,
 };
 
 enum SHOW_BUTTONS {
   SHOW_NO_BUTTONS    = 0,
   SHOW_BUTTON_RELOAD = 1,
 };
 
 struct LocalizedErrorMap {
   int error_code;
   unsigned int heading_resource_id;
@@ skipping 157 matching lines @@
   },
   {net::ERR_SSL_PROTOCOL_ERROR,
    IDS_ERRORPAGES_HEADING_INSECURE_CONNECTION,
    IDS_ERRORPAGES_SUMMARY_INVALID_RESPONSE,
    SUGGEST_DIAGNOSE_TOOL,
    SHOW_BUTTON_RELOAD,
   },
   {net::ERR_BAD_SSL_CLIENT_AUTH_CERT,
    IDS_ERRORPAGES_HEADING_INSECURE_CONNECTION,
    IDS_ERRORPAGES_SUMMARY_BAD_SSL_CLIENT_AUTH_CERT,
-   SUGGEST_CONTACT_ADMINISTRATOR,
-   SHOW_NO_BUTTONS,
+   SUGGEST_CONTACT_ADMINISTRATOR | SUGGEST_CLIENT_CERTIFICATE,
+   SHOW_BUTTON_RELOAD,
   },
   {net::ERR_SSL_WEAK_SERVER_EPHEMERAL_DH_KEY,
    IDS_ERRORPAGES_HEADING_INSECURE_CONNECTION,
    IDS_ERRORPAGES_SUMMARY_SSL_SECURITY_ERROR,
    SUGGEST_LEARNMORE,
    SHOW_NO_BUTTONS,
   },
   {net::ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN,
    IDS_ERRORPAGES_HEADING_INSECURE_CONNECTION,
    IDS_CERT_ERROR_SUMMARY_PINNING_FAILURE_DETAILS,
@@ skipping 381 matching lines @@
         IDS_ERRORPAGES_SUGGESTION_DISABLE_EXTENSION_SUMMARY, false);
     return;
   }
   DCHECK(!IsSuggested(suggestions, SUGGEST_DISABLE_EXTENSION));
 
   if (suggestions & SUGGEST_CHECK_CONNECTION) {
     AddSingleEntryDictionaryToList(suggestions_summary_list, "summary",
         IDS_ERRORPAGES_SUGGESTION_CHECK_CONNECTION_SUMMARY, false);
   }
 
+  if (suggestions & SUGGEST_CLIENT_CERTIFICATE) {
+    AddSingleEntryDictionaryToList(suggestions_summary_list, "summary",
+                                   IDS_ERRORPAGES_SUGGESTION_CLIENT_CERTIFICATE,
+                                   false);
+  }
+
 #if !defined(OS_ANDROID) && !defined(OS_IOS)
   if (IsSuggested(suggestions, SUGGEST_DNS_CONFIG) &&
       IsSuggested(suggestions, SUGGEST_FIREWALL_CONFIG) &&
       IsSuggested(suggestions, SUGGEST_PROXY_CONFIG)) {
     AddSingleEntryDictionaryToList(suggestions_summary_list, "summary",
         IDS_ERRORPAGES_SUGGESTION_CHECK_PROXY_FIREWALL_DNS_SUMMARY, false);
   } else if (IsSuggested(suggestions, SUGGEST_FIREWALL_CONFIG) &&
              IsSuggested(suggestions, SUGGEST_ANTIVIRUS_CONFIG)) {
     AddSingleEntryDictionaryToList(suggestions_summary_list, "summary",
         IDS_ERRORPAGES_SUGGESTION_CHECK_FIREWALL_ANTIVIRUS_SUMMARY, false);
@@ skipping 360 matching lines @@
 
 bool LocalizedError::HasStrings(const std::string& error_domain,
                                 int error_code) {
   // Whether or not the there are strings for an error does not depend on
   // whether or not the page was be generated by a POST, so just claim it was
   // not.
   return LookupErrorMap(error_domain, error_code, /*is_post=*/false) != nullptr;
 }
 
 }  // namespace error_page