Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4661)

Unified Diff: chrome/common/page_load_metrics/page_track_decider.cc

Issue 2350473002: [page_load_metrics] Add support for chrome:// urls and add extensions observer (Closed)
Patch Set: use url constant Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/page_load_metrics/page_track_decider.cc
diff --git a/chrome/common/page_load_metrics/page_track_decider.cc b/chrome/common/page_load_metrics/page_track_decider.cc
index 457532a83f03eabfa76740f5d563d62c41859977..dd415c0c890a59c2fc1731beaadf1fc3c5471576 100644
--- a/chrome/common/page_load_metrics/page_track_decider.cc
+++ b/chrome/common/page_load_metrics/page_track_decider.cc
@@ -10,14 +10,13 @@ PageTrackDecider::PageTrackDecider() {}
PageTrackDecider::~PageTrackDecider() {}
bool PageTrackDecider::ShouldTrack() {
- // Ignore non-HTTP schemes (e.g. chrome://).
- if (!IsHttpOrHttpsUrl())
- return false;
-
// Ignore NTP loads.
if (IsNewTabPageUrl())
return false;
+ if (IsAboutBlankUrl())
+ return false;
+
if (HasCommitted()) {
// Ignore Chrome error pages (e.g. No Internet connection).
if (IsChromeErrorPage())

Powered by Google App Engine
This is Rietveld 408576698