chrome/renderer/page_load_metrics/renderer_page_track_decider.h - Issue 2350473002: [page_load_metrics] Add support for chrome:// urls and add extensions observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/page_load_metrics/renderer_page_track_decider.h

Issue 2350473002: [page_load_metrics] Add support for chrome:// urls and add extensions observer (Closed)

Patch Set: use url constant Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/page_load_metrics/renderer_page_track_decider.h

diff --git a/chrome/renderer/page_load_metrics/renderer_page_track_decider.h b/chrome/renderer/page_load_metrics/renderer_page_track_decider.h

index 2bcc659ca9a81cdd74274e5118dfcd7554040bce..f5342ca0e7d995e4222f8c294c97acd7972273ec 100644

--- a/chrome/renderer/page_load_metrics/renderer_page_track_decider.h

+++ b/chrome/renderer/page_load_metrics/renderer_page_track_decider.h

@@ -24,8 +24,8 @@ class RendererPageTrackDecider : public PageTrackDecider {

~RendererPageTrackDecider() override;

bool HasCommitted() override;

- bool IsHttpOrHttpsUrl() override;

bool IsNewTabPageUrl() override;

+ bool IsAboutBlankUrl() override;

bool IsChromeErrorPage() override;

bool IsHtmlOrXhtmlPage() override;

int GetHttpStatusCode() override;