Issue 2350463002: [chromedriver] Avoid calling Runtime.evaluate when a dialog is showing.

Issue 2350463002: [chromedriver] Avoid calling Runtime.evaluate when a dialog is showing. (Closed)

Created:
4 years, 3 months ago by samuong

Modified:
4 years, 3 months ago

Reviewers:
stgao

CC:
chromium-reviews, samuong+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[chromedriver] Avoid calling Runtime.evaluate when a dialog is showing. BUG=chromedriver:1514 Committed: https://crrev.com/2b8162ec04252bf23869c4753710af6d659d6478 Cr-Commit-Position: refs/heads/master@{#420052}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	chrome/test/chromedriver/session_commands.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
	M	chrome/test/chromedriver/test/run_py_tests.py	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 12 (5 generated)

stgao

lgtm One suggestion: it would be nice to ask infra team to make the bug ...

4 years, 3 months ago (2016-09-20 23:24:00 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350463002/1

4 years, 3 months ago (2016-09-21 14:28:20 UTC) #8

commit-bot: I haz the power

4 years, 3 months ago (2016-09-21 14:46:39 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2b8162ec04252bf23869c4753710af6d659d6478
Cr-Commit-Position: refs/heads/master@{#420052}