Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3585)

Unified Diff: chrome/test/chromedriver/test/run_py_tests.py

Issue 2350463002: [chromedriver] Avoid calling Runtime.evaluate when a dialog is showing. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/session_commands.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/test/run_py_tests.py
diff --git a/chrome/test/chromedriver/test/run_py_tests.py b/chrome/test/chromedriver/test/run_py_tests.py
index 87ad41a41583ac2a708b5934b93f5a32042751e4..9e915c2dca214e4d579a58246335f39c8e75734c 100755
--- a/chrome/test/chromedriver/test/run_py_tests.py
+++ b/chrome/test/chromedriver/test/run_py_tests.py
@@ -862,6 +862,14 @@ class ChromeDriverTest(ChromeDriverBaseTestWithWebServer):
except chromedriver.ChromeDriverException as e:
self.fail('exception while calling GetLog on a closed tab: ' + e.message)
+ def testGetLogOnWindowWithAlert(self):
+ self._driver.Load(self.GetHttpUrlForFile('/chromedriver/empty.html'))
+ self._driver.ExecuteScript('alert("alert!");')
+ try:
+ self._driver.GetLog('browser')
+ except Exception as e:
+ self.fail(e.message)
+
def testAutoReporting(self):
self.assertFalse(self._driver.IsAutoReporting())
self._driver.SetAutoReporting(True)
« no previous file with comments | « chrome/test/chromedriver/session_commands.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698