Reset clip parent in CompositedLayerMapping::updateClipParent

Reset clip parent in CompositedLayerMapping::updateClipParent

Reset clip parent instead of skipping update clip parent when
owningLayerClippedByLayerNotAboveCompositedAncestor(scrollParent) returns true.

This avoids having stale clip parent when the above-mentioned value switched
from false to true. Having stale clip parent result in inconsistent rendering
comparing to a static page that has a true value since beginning.

Technically it is still incorrect but fixing every case of clip escaping is
out of the scope of this CL.

BUG=647508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/1de92f8c7df73309f3f192c14cb6755ddea380b5
Cr-Commit-Position: refs/heads/master@{#421395}

[trchen, 2016-09-21 00:41:17]

Description was changed from

==========
Reset clip parent in CompositedLayerMapping::updateClipParent

Reset clip parent instead of skipping update clip parent when
owningLayerClippedByLayerNotAboveCompositedAncestor(scrollParent) returns true.

This avoids having stale clip parent when the above-mentioned value switched
from false to true. Having stale clip parent result in inconsistent rendering
comparing to a static page that has a true value since beginning.

Technically it is still incorrect but fixing every case of clip escaping is
out of the scope of this CL.

BUG=647508
==========

to

==========
Reset clip parent in CompositedLayerMapping::updateClipParent

Reset clip parent instead of skipping update clip parent when
owningLayerClippedByLayerNotAboveCompositedAncestor(scrollParent) returns true.

This avoids having stale clip parent when the above-mentioned value switched
from false to true. Having stale clip parent result in inconsistent rendering
comparing to a static page that has a true value since beginning.

Technically it is still incorrect but fixing every case of clip escaping is
out of the scope of this CL.

BUG=647508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[trchen, 2016-09-21 00:41:40]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 00:42:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[trchen, 2016-09-21 00:43:04]

trchen@chromium.org changed reviewers:
+ vollick@chromium.org

[commit-bot: I haz the power, 2016-09-21 01:57:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 01:57:48]

Dry run: This issue passed the CQ dry run.

[Ian Vollick, 2016-09-21 04:12:14]

On 2016/09/21 00:43:04, trchen wrote:

This makes tons of sense. Is it possible to reduce the bug into a test?

[trchen, 2016-09-26 23:57:38]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[trchen, 2016-09-26 23:57:48]

Done!

[commit-bot: I haz the power, 2016-09-26 23:58:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 01:24:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 01:24:55]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[Ian Vollick, 2016-09-27 02:15:46]

On 2016/09/26 23:57:48, trchen wrote:
> Done!

lgtm if the bots are happy (is the SPv2 test failure real?)

[trchen, 2016-09-27 22:48:44]

SPv2 doesn't group opacity properly yet. I believe ajuma is working on delaying
render surface calculation until draw.

[trchen, 2016-09-27 22:48:48]

The CQ bit was checked by trchen@chromium.org

[trchen, 2016-09-27 22:48:48]

The patchset sent to the CQ was uploaded after l-g-t-m from vollick@chromium.org
Link to the patchset: https://codereview.chromium.org/2350363004/#ps40001
(title: "spv2 expectation")

[commit-bot: I haz the power, 2016-09-27 22:49:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 00:14:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-28 00:18:28]

Description was changed from

==========
Reset clip parent in CompositedLayerMapping::updateClipParent

Reset clip parent instead of skipping update clip parent when
owningLayerClippedByLayerNotAboveCompositedAncestor(scrollParent) returns true.

This avoids having stale clip parent when the above-mentioned value switched
from false to true. Having stale clip parent result in inconsistent rendering
comparing to a static page that has a true value since beginning.

Technically it is still incorrect but fixing every case of clip escaping is
out of the scope of this CL.

BUG=647508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Reset clip parent in CompositedLayerMapping::updateClipParent

Reset clip parent instead of skipping update clip parent when
owningLayerClippedByLayerNotAboveCompositedAncestor(scrollParent) returns true.

This avoids having stale clip parent when the above-mentioned value switched
from false to true. Having stale clip parent result in inconsistent rendering
comparing to a static page that has a true value since beginning.

Technically it is still incorrect but fixing every case of clip escaping is
out of the scope of this CL.

BUG=647508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/1de92f8c7df73309f3f192c14cb6755ddea380b5
Cr-Commit-Position: refs/heads/master@{#421395}
==========

[commit-bot: I haz the power, 2016-09-28 00:18:29]

Patchset 3 (id:??) landed as
https://crrev.com/1de92f8c7df73309f3f192c14cb6755ddea380b5
Cr-Commit-Position: refs/heads/master@{#421395}