Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2350363004: Reset clip parent in CompositedLayerMapping::updateClipParent (Closed)
Patch Set: spv2 expectation Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/overflow/clip-parent-reset-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
index ed610b05797324f8ef7c6b5d3a842d5ab157b6a5..6695045de435e5514d7efebff111ee7687a59753 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
@@ -1817,12 +1817,12 @@ static void updateClipParentForGraphicsLayer(GraphicsLayer* layer, GraphicsLayer
void CompositedLayerMapping::updateClipParent(const PaintLayer* scrollParent)
{
- if (owningLayerClippedByLayerNotAboveCompositedAncestor(scrollParent))
- return;
-
- const PaintLayer* clipParent = m_owningLayer.clipParent();
- if (clipParent)
- clipParent = clipParent->enclosingLayerWithCompositedLayerMapping(IncludeSelf);
+ const PaintLayer* clipParent = nullptr;
+ if (!owningLayerClippedByLayerNotAboveCompositedAncestor(scrollParent)) {
+ clipParent = m_owningLayer.clipParent();
+ if (clipParent)
+ clipParent = clipParent->enclosingLayerWithCompositedLayerMapping(IncludeSelf);
+ }
if (ScrollingCoordinator* scrollingCoordinator = scrollingCoordinatorFromLayer(m_owningLayer)) {
GraphicsLayer* topmostLayer = childForSuperlayers();
« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/overflow/clip-parent-reset-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698