Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(357)

Issue 235033003: Make test/cxxflags use a user define instead of __OPTIMIZE__ (Closed)

Created:
6 years, 6 months ago by scottmg
Modified:
6 years, 6 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com, Nils Barth (inactive)
Visibility:
Public.

Description

Make test/cxxflags use a user define instead of __OPTIMIZE__ __OPTIMIZE__ is a gcc-specific define, so this was broken on Windows after https://code.google.com/p/gyp/source/detail?r=1893. R=thakis@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1895

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M test/cxxflags/cxxflags.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cxxflags/cxxflags.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cxxflags/gyptest-cxxflags.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
trybots seem to be awol again, but this passes locally on win/linux for me.
6 years, 6 months ago (2014-04-14 16:15:30 UTC) #1
Nico
lgtm Thanks for tracking this down!
6 years, 6 months ago (2014-04-14 16:29:03 UTC) #2
scottmg
6 years, 6 months ago (2014-04-14 16:30:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1895 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698