Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1623)

Unified Diff: test/cxxflags/gyptest-cxxflags.py

Issue 235033003: Make test/cxxflags use a user define instead of __OPTIMIZE__ (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cxxflags/cxxflags.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cxxflags/gyptest-cxxflags.py
diff --git a/test/cxxflags/gyptest-cxxflags.py b/test/cxxflags/gyptest-cxxflags.py
index b8bed7f9c2c5a6c102e1ea2a70adf46f08ef309a..117a1800de49d3202a0244a9822140c80585940d 100755
--- a/test/cxxflags/gyptest-cxxflags.py
+++ b/test/cxxflags/gyptest-cxxflags.py
@@ -20,25 +20,25 @@ test = TestGyp.TestGyp(formats=FORMATS)
# We reset the environ after calling gyp. When the auto-regeneration happens,
# the same define should be reused anyway.
-with TestGyp.LocalEnv({'CXXFLAGS': '-O0'}):
+with TestGyp.LocalEnv({'CXXFLAGS': ''}):
test.run_gyp('cxxflags.gyp')
test.build('cxxflags.gyp')
expect = """\
-Using no optimization flag
+No define
"""
test.run_built_executable('cxxflags', stdout=expect)
test.sleep()
-with TestGyp.LocalEnv({'CXXFLAGS': '-O2'}):
+with TestGyp.LocalEnv({'CXXFLAGS': '-DABC'}):
test.run_gyp('cxxflags.gyp')
test.build('cxxflags.gyp')
expect = """\
-Using an optimization flag
+With define
"""
test.run_built_executable('cxxflags', stdout=expect)
« no previous file with comments | « test/cxxflags/cxxflags.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698