Make the MockDRT implementation work again and add support for --actuals.

Make the MockDRT implementation work again and add support for --actuals.

This fixes a bunch of issues that had broken over the months in the mock drt
code. Initial patch was from bungeman@chromium.org in
https://codereview.chromium.org/23889025/ . I've fixed the remaining issues
with the unit tests, fixed issues related to handling audio tests and virtual
test suites, and removed support for old test-shell style driver logic.

This code really shouldn't be called mock_drt at all, since drt doesn't
exist any more, either, but I'll save that for another day.

R=ojan@chromium.org, bungeman@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158235

[bungeman-chromium, 2013-09-20 22:35:17]

https://codereview.chromium.org/23503087/diff/5001/Tools/Scripts/webkitpy/lay...
File Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py (right):

https://codereview.chromium.org/23503087/diff/5001/Tools/Scripts/webkitpy/lay...
Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py:164: options =
optparse.Values({'actual_directory': actual_directory,
Arg, my OCD! Any reason these are in a different order from just above?

https://codereview.chromium.org/23503087/diff/5001/Tools/Scripts/webkitpy/lay...
Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py:271: if
test_input.should_run_pixel_test and output.image_hash:
I think I added ' or is_reftest' here in my original for some reason and I must
admit I don't entirely remember why. I seem to recall that I added it because
something was failing. Anyhow, something to keep in mind.

[Dirk Pranke, 2013-09-20 22:41:00]

https://codereview.chromium.org/23503087/diff/5001/Tools/Scripts/webkitpy/lay...
File Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py (right):

https://codereview.chromium.org/23503087/diff/5001/Tools/Scripts/webkitpy/lay...
Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py:164: options =
optparse.Values({'actual_directory': actual_directory,
On 2013/09/20 22:35:17, bungeman2 wrote:
> Arg, my OCD! Any reason these are in a different order from just above?

No good reason. Will fix.

https://codereview.chromium.org/23503087/diff/5001/Tools/Scripts/webkitpy/lay...
Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py:271: if
test_input.should_run_pixel_test and output.image_hash:
On 2013/09/20 22:35:17, bungeman2 wrote:
> I think I added ' or is_reftest' here in my original for some reason and I
must
> admit I don't entirely remember why. I seem to recall that I added it because
> something was failing. Anyhow, something to keep in mind.

Yeah, you needed to add it to work around the calling code doing the wrong thing
w/ self._options.pixel_tests . Once I got rid of the global --pixel-test flag to
use the per-test flag and updated the calling code, you didn't need the
additional check any more.

[Dirk Pranke, 2013-09-20 22:44:19]

patch updated w/ review comments.

[bungeman-skia, 2013-09-20 22:55:15]

lgtm

[bungeman-chromium, 2013-09-23 13:23:57]

lgtm 2

[commit-bot: I haz the power, 2013-09-23 20:16:56]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Dirk Pranke, 2013-09-23 21:44:37]

On 2013/09/23 20:16:56, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a lowly provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

Whoops, I thought Ojan had chimed in on this. Ojan, can you take a look?

[ojan, 2013-09-24 00:26:44]

lgtm

[commit-bot: I haz the power, 2013-09-24 00:26:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpranke@chromium.org/23503087/11001

[commit-bot: I haz the power, 2013-09-24 04:21:38]

Change committed as 158235