Fix memory leak in app_controller_mac.mm.

Fix memory leak in app_controller_mac.mm.

Found by the Mac OS X 'leaks' tool; fixed on a plane.

BUG=292905
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223522

[Nico, 2013-09-16 21:05:28]

lgtm

https://codereview.chromium.org/23503065/diff/1/chrome/browser/app_controller...
File chrome/browser/app_controller_mac.mm (right):

https://codereview.chromium.org/23503065/diff/1/chrome/browser/app_controller...
chrome/browser/app_controller_mac.mm:175:
base::SysUTF8ToCFStringRef(app_bundle_path.value()));
This on the other hand is just surprising API. Every time we fix one of these I
look at all callers of this function.

[Alexei Svitkine (slow), 2013-09-16 21:07:25]

https://codereview.chromium.org/23503065/diff/1/chrome/browser/app_controller...
File chrome/browser/app_controller_mac.mm (right):

https://codereview.chromium.org/23503065/diff/1/chrome/browser/app_controller...
chrome/browser/app_controller_mac.mm:175:
base::SysUTF8ToCFStringRef(app_bundle_path.value()));
On 2013/09/16 21:05:28, Nico wrote:
> This on the other hand is just surprising API. Every time we fix one of these
I
> look at all callers of this function.

Yeah, we should rename the API.

[commit-bot: I haz the power, 2013-09-16 21:07:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/23503065/1

[commit-bot: I haz the power, 2013-09-16 23:02:11]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-16 23:03:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/23503065/1

[commit-bot: I haz the power, 2013-09-17 03:38:14]

Change committed as 223522