Fix memory leak in app_controller_mac.mm.

chrome/browser/app_controller_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/app_controller_mac.h"
 
 #include "apps/app_shim/app_shim_mac.h"
 #include "apps/app_shim/extension_app_shim_handler_mac.h"
 #include "apps/shell_window_registry.h"
 #include "base/auto_reset.h"
@@ skipping 151 matching lines @@
 // Record the location of the application bundle (containing the main framework)
 // from which Chromium was loaded. This is used by app mode shims to find
 // Chromium.
 void RecordLastRunAppBundlePath() {
   // Going up three levels from |chrome::GetVersionedDirectory()| gives the
   // real, user-visible app bundle directory. (The alternatives give either the
   // framework's path or the initial app's path, which may be an app mode shim
   // or a unit test.)
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
 
-  base::FilePath appBundlePath =
+  base::FilePath app_bundle_path =
       chrome::GetVersionedDirectory().DirName().DirName().DirName();
+  base::ScopedCFTypeRef<CFStringRef> app_bundle_path_cfstring(
+      base::SysUTF8ToCFStringRef(app_bundle_path.value()));

[Nico, 2013/09/16 21:05:28]

This on the other hand is just surprising API. Every time we fix one of these I
look at all callers of this function.

[Alexei Svitkine (slow), 2013/09/16 21:07:25]

Yeah, we should rename the API.

   CFPreferencesSetAppValue(
       base::mac::NSToCFCast(app_mode::kLastRunAppBundlePathPrefsKey),
-      base::SysUTF8ToCFStringRef(appBundlePath.value()),
-      BaseBundleID_CFString());
+      app_bundle_path_cfstring, BaseBundleID_CFString());
 
   // Sync after a delay avoid I/O contention on startup; 1500 ms is plenty.
   BrowserThread::PostDelayedTask(
       BrowserThread::FILE, FROM_HERE,
       base::Bind(&PrefsSyncCallback),
       base::TimeDelta::FromMilliseconds(1500));
 }
 
 }  // anonymous namespace
 
@@ skipping 1233 matching lines @@
 
 //---------------------------------------------------------------------------
 
 namespace app_controller_mac {
 
 bool IsOpeningNewWindow() {
   return g_is_opening_new_window;
 }
 
 }  // namespace app_controller_mac