Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 2350303005: Fix a DCHECK failure in PopupMenuImpl::setValueAndClosePopup(). (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a DCHECK failure in PopupMenuImpl::setValueAndClosePopup(). |stringValue| may be empty. BUG=629029 Committed: https://crrev.com/676be06451fec4d4f2f0bab075f3b627ec1d1597 Cr-Commit-Position: refs/heads/master@{#419991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-key-operations.html View 2 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/forms/select-popup/popup-menu-key-operations-expected.txt View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
Hattori-san, would you review this please?
4 years, 3 months ago (2016-09-21 05:40:59 UTC) #5
keishi
LGTM
4 years, 3 months ago (2016-09-21 05:59:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350303005/1
4 years, 3 months ago (2016-09-21 06:56:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 07:03:08 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 07:06:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/676be06451fec4d4f2f0bab075f3b627ec1d1597
Cr-Commit-Position: refs/heads/master@{#419991}

Powered by Google App Engine
This is Rietveld 408576698