Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-key-operations.html

Issue 2350303005: Fix a DCHECK failure in PopupMenuImpl::setValueAndClosePopup(). (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/platform/win/fast/forms/select-popup/popup-menu-key-operations-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-key-operations.html
diff --git a/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-key-operations.html b/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-key-operations.html
index 54febb5531d83384104b2a9422b5a7160fbcf04b..9287cbb4d72ad5e11d693f1a5720955ceff2e64c 100644
--- a/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-key-operations.html
+++ b/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-key-operations.html
@@ -14,9 +14,14 @@
<option>garply</option>
</optgroup>
</select>
+<select id="menu2">
+ <option>abc</option>
+ <option>xyz</option>
+</select>
<div id="console"></div>
<script>
var menu = document.getElementById('menu');
+var menu2 = document.getElementById('menu2');
var picker = null;
function openPickerErrorCallback() {
testFailed('picker didn\'t open')
@@ -171,6 +176,19 @@ function test6() {
shouldBeEqualToString('menu.value', 'foo');
shouldBeEqualToString('internals.selectMenuListText(menu)', 'foo');
+ waitUntilClosing(() => {
+ menu2.selectedIndex = -1;
+ openPicker(menu2, testEnterWithoutSelection, openPickerErrorCallback);
+ });
+}
+
+function testEnterWithoutSelection() {
+ picker = window.internals.pagePopupWindow.global.picker;
+ shouldBeEqualToString('picker._selectElement.value', '');
+ eventSender.keyDown('Enter');
+ shouldBeNull('window.internals.pagePopupWindow');
+ shouldBeEqualToString('menu2.value', '');
+
finishJSTest();
}
</script>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/platform/win/fast/forms/select-popup/popup-menu-key-operations-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698