Site Settings Desktop: Fix crash when altering exception.

Site Settings Desktop: Fix crash when altering exception.

TBR=michaelpg
BUG=644998
Committed: https://crrev.com/55049afd01bed47611e8a131c30af6c0e7415f83
Cr-Commit-Position: refs/heads/master@{#419925}

[Finnur, 2016-09-20 14:22:52]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 14:23:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 15:05:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 15:05:33]

Dry run: This issue passed the CQ dry run.

[Finnur, 2016-09-20 15:07:42]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 15:08:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Finnur, 2016-09-20 15:46:12]

finnur@chromium.org changed reviewers:
+ dschuyler@chromium.org

[Finnur, 2016-09-20 15:46:13]

https://codereview.chromium.org/2350303004/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/site_settings_helper.cc (right):

https://codereview.chromium.org/2350303004/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/site_settings_helper.cc:97:
exception->SetBoolean(site_settings::kIncognito, false);
The changes in this file are purely code moving from one location to another --
with the exception of this line, which is new and fixes the crash. With the new
test I added, if you remove this line or line 124 (or any of the important ones,
in fact), the test will catch it.

[commit-bot: I haz the power, 2016-09-20 16:08:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 16:08:49]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-09-20 18:54:41]

lgtm

https://codereview.chromium.org/2350303004/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc (right):

https://codereview.chromium.org/2350303004/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc:278:
args.AppendString("notifications");  // Picked at random.
optional: maybe the comment could be // Arbitrary.
Or // Chosen arbitrarily.
Though there's not a lot of people who will care
so much about how the word 'random' is used, so 
it probably doesn't matter.

[Finnur, 2016-09-21 00:01:12]

Description was changed from

==========
Site Settings Desktop: Fix crash when altering exception.

BUG=644998
==========

to

==========
Site Settings Desktop: Fix crash when altering exception.

TBR=michaelpg
BUG=644998
==========

[Finnur, 2016-09-21 00:01:12]

finnur@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Finnur, 2016-09-21 00:02:28]

Updated. Also adding Michael as TBR for OWNERS approval of
site_settings_helper.* (since I am technically owner of it and this is just a
code move). Happy to do follow-ups, if something needs addressing.

[Finnur, 2016-09-21 00:03:02]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2016-09-21 00:03:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2350303004/#ps40001
(title: "Address feedback")

[commit-bot: I haz the power, 2016-09-21 00:03:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 00:53:30]

Description was changed from

==========
Site Settings Desktop: Fix crash when altering exception.

TBR=michaelpg
BUG=644998
==========

to

==========
Site Settings Desktop: Fix crash when altering exception.

TBR=michaelpg
BUG=644998
==========

[commit-bot: I haz the power, 2016-09-21 00:53:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-21 00:55:44]

Description was changed from

==========
Site Settings Desktop: Fix crash when altering exception.

TBR=michaelpg
BUG=644998
==========

to

==========
Site Settings Desktop: Fix crash when altering exception.

TBR=michaelpg
BUG=644998

Committed: https://crrev.com/55049afd01bed47611e8a131c30af6c0e7415f83
Cr-Commit-Position: refs/heads/master@{#419925}
==========

[commit-bot: I haz the power, 2016-09-21 00:55:45]

Patchset 3 (id:??) landed as
https://crrev.com/55049afd01bed47611e8a131c30af6c0e7415f83
Cr-Commit-Position: refs/heads/master@{#419925}