Site Settings Desktop: Fix crash when altering exception.

chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/settings/site_settings_handler.h"
 
 #include <memory>
 
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/ui/webui/site_settings_helper.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/content_settings/core/common/content_settings.h"
 #include "components/content_settings/core/common/content_settings_types.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/web_ui_data_source.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "content/public/test/test_web_ui.h"
+#include "extensions/common/extension_builder.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 const char kCallbackId[] = "test-callback-id";
 
 }
 
 namespace settings {
 
@@ skipping 221 matching lines @@
   resetArgs.AppendString("notifications");
   resetArgs.AppendBoolean(false);  // Incognito.
   handler()->HandleResetCategoryPermissionForOrigin(&resetArgs);
   EXPECT_EQ(3U, web_ui()->call_data().size());
 
   // Verify the reset was successful.
   handler()->HandleGetExceptionList(&listArgs);
   ValidateNoOrigin(4U);
 }
 
+TEST_F(SiteSettingsHandlerTest, ExceptionHelpers) {
+  ContentSettingsPattern pattern =
+      ContentSettingsPattern::FromString("[*.]google.com");
+  std::unique_ptr<base::DictionaryValue> exception =
+      site_settings::GetExceptionForPage(pattern, pattern,
+          CONTENT_SETTING_BLOCK, "preference", false);
+
+  std::string primary_pattern, secondary_pattern, type;
+  bool incognito;
+  CHECK(exception->GetString(site_settings::kOrigin, &primary_pattern));
+  CHECK(exception->GetString(site_settings::kEmbeddingOrigin,
+                             &secondary_pattern));
+  CHECK(exception->GetString(site_settings::kSetting, &type));
+  CHECK(exception->GetBoolean(site_settings::kIncognito, &incognito));
+
+  base::ListValue args;
+  args.AppendString(primary_pattern);
+  args.AppendString(secondary_pattern);
+  args.AppendString("notifications");  // Chosen arbitrarily.
+  args.AppendString(type);
+  args.AppendBoolean(incognito);
+
+  // We don't need to check the results. This is just to make sure it doesn't
+  // crash on the input.
+  handler()->HandleSetCategoryPermissionForOrigin(&args);
+
+  scoped_refptr<const extensions::Extension> extension;
+  extension = extensions::ExtensionBuilder()
+                  .SetManifest(extensions::DictionaryBuilder()
+                                   .Set("name", "Test extension")
+                                   .Set("version", "1.0.0")
+                                   .Set("manifest_version", 2)
+                                   .Build())
+                  .SetID("ahfgeienlihckogmohjhadlkjgocpleb")
+                  .Build();
+
+  std::unique_ptr<base::ListValue> exceptions(new base::ListValue);
+  site_settings::AddExceptionForHostedApp(
+      "[*.]google.com", *extension.get(), exceptions.get());
+
+  const base::DictionaryValue* dictionary;
+  CHECK(exceptions->GetDictionary(0, &dictionary));
+  CHECK(dictionary->GetString(site_settings::kOrigin, &primary_pattern));
+  CHECK(dictionary->GetString(site_settings::kEmbeddingOrigin,
+                              &secondary_pattern));
+  CHECK(dictionary->GetString(site_settings::kSetting, &type));
+  CHECK(dictionary->GetBoolean(site_settings::kIncognito, &incognito));
+
+  // Again, don't need to check the results.
+  handler()->HandleSetCategoryPermissionForOrigin(&args);
+}
+
 TEST_F(SiteSettingsHandlerTest, Patterns) {
   base::ListValue args;
   std::string pattern("[*.]google.com");
   args.AppendString(kCallbackId);
   args.AppendString(pattern);
   handler()->HandleIsPatternValid(&args);
   ValidatePattern(true, 1U);
 
   base::ListValue invalid;
   std::string bad_pattern(";");
@@ skipping 31 matching lines @@
   args.AppendString("http://www.google.com");
   handler()->HandleRemoveZoomLevel(&args);
   ValidateZoom("", "", 3U);
 
   double default_level = host_zoom_map->GetDefaultZoomLevel();
   double level = host_zoom_map->GetZoomLevelForHostAndScheme("http", host);
   EXPECT_EQ(default_level, level);
 }
 
 }  // namespace settings