Replace FilterData::filter with lastEffect

Replace FilterData::filter with lastEffect

This brings the FilterData+SVGFilterPainter (etc)  "complex" closer to
the PaintLayer+PaintLayerFilterInfo structure by keep the last effect
in the chain and accessing the Filter through that when needed.
In general we want these two "complexes" to closely resemble each other
as possible - because they are supposed to implement the same thing, with
only a difference in the parametrization (like which bounding-box to use.)
This also brings one tiny (tiny tiny) step closer to being able to get
shorthand filters working in the SVG code-path.

Also try to reduce dependencies a bit in the surrounding code.

BUG=439970, 109224
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/28dabf9ae1ddd829b228ca519f38f317aff7fc97
Cr-Commit-Position: refs/heads/master@{#419700}

[fs, 2016-09-19 14:04:24]

Description was changed from

==========
Replace FilterData::filter with lastEffect

This brings the FilterData+SVGFilterPainter (etc)  "complex" closer to
the PaintLayer+PaintLayerFilterInfo structure by keep the last effect
in the chain and accessing the Filter through that when needed.

Also try to reduce dependencies a bit in the surrounding code.

BUG=439970,109224
==========

to

==========
Replace FilterData::filter with lastEffect

This brings the FilterData+SVGFilterPainter (etc)  "complex" closer to
the PaintLayer+PaintLayerFilterInfo structure by keep the last effect
in the chain and accessing the Filter through that when needed.

Also try to reduce dependencies a bit in the surrounding code.

BUG=439970,109224
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-19 14:04:36]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 14:04:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-09-19 15:21:42]

fs@opera.com changed reviewers:
+ pdr@chromium.org, schenney@chromium.org

[commit-bot: I haz the power, 2016-09-19 15:27:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 15:27:40]

Dry run: This issue passed the CQ dry run.

[Stephen Chennney, 2016-09-19 15:33:55]

The code change is LGTM. Could you modify the change description to indicate why
we want the PaintLayer and SVG filter complexes to look more alike. I presume we
want to merge them and I would like an explicit statement.

[fs, 2016-09-19 16:02:06]

Description was changed from

==========
Replace FilterData::filter with lastEffect

This brings the FilterData+SVGFilterPainter (etc)  "complex" closer to
the PaintLayer+PaintLayerFilterInfo structure by keep the last effect
in the chain and accessing the Filter through that when needed.

Also try to reduce dependencies a bit in the surrounding code.

BUG=439970,109224
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Replace FilterData::filter with lastEffect

This brings the FilterData+SVGFilterPainter (etc)  "complex" closer to
the PaintLayer+PaintLayerFilterInfo structure by keep the last effect
in the chain and accessing the Filter through that when needed.
In general we want these two "complexes" to closely resemble each other
as possible - because they are supposed to implement the same thing, with
only a difference in the parametrization (like which bounding-box to use.)
This also brings one tiny (tiny tiny) step closer to being able to get
shorthand filters working in the SVG code-path.

Also try to reduce dependencies a bit in the surrounding code.

BUG=439970,109224
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-19 16:03:11]

On 2016/09/19 at 15:33:55, schenney wrote:
> The code change is LGTM. Could you modify the change description to indicate
why we want the PaintLayer and SVG filter complexes to look more alike. I
presume we want to merge them and I would like an explicit statement.

Yes, I suspect a fullblown merge may not be around the corner, but I want get as
close a possible at least. I expanded the description a bit in that regard.

[pdr., 2016-09-19 20:45:21]

On 2016/09/19 at 16:03:11, fs wrote:
> On 2016/09/19 at 15:33:55, schenney wrote:
> > The code change is LGTM. Could you modify the change description to indicate
why we want the PaintLayer and SVG filter complexes to look more alike. I
presume we want to merge them and I would like an explicit statement.
> 
> Yes, I suspect a fullblown merge may not be around the corner, but I want get
as close a possible at least. I expanded the description a bit in that regard.

LGTM

[fs, 2016-09-20 08:25:34]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-09-20 08:25:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 08:33:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 08:33:30]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[commit-bot: I haz the power, 2016-09-20 08:34:48]

Description was changed from

==========
Replace FilterData::filter with lastEffect

This brings the FilterData+SVGFilterPainter (etc)  "complex" closer to
the PaintLayer+PaintLayerFilterInfo structure by keep the last effect
in the chain and accessing the Filter through that when needed.
In general we want these two "complexes" to closely resemble each other
as possible - because they are supposed to implement the same thing, with
only a difference in the parametrization (like which bounding-box to use.)
This also brings one tiny (tiny tiny) step closer to being able to get
shorthand filters working in the SVG code-path.

Also try to reduce dependencies a bit in the surrounding code.

BUG=439970,109224
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Replace FilterData::filter with lastEffect

This brings the FilterData+SVGFilterPainter (etc)  "complex" closer to
the PaintLayer+PaintLayerFilterInfo structure by keep the last effect
in the chain and accessing the Filter through that when needed.
In general we want these two "complexes" to closely resemble each other
as possible - because they are supposed to implement the same thing, with
only a difference in the parametrization (like which bounding-box to use.)
This also brings one tiny (tiny tiny) step closer to being able to get
shorthand filters working in the SVG code-path.

Also try to reduce dependencies a bit in the surrounding code.

BUG=439970,109224
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/28dabf9ae1ddd829b228ca519f38f317aff7fc97
Cr-Commit-Position: refs/heads/master@{#419700}
==========

[commit-bot: I haz the power, 2016-09-20 08:34:52]

Patchset 1 (id:??) landed as
https://crrev.com/28dabf9ae1ddd829b228ca519f38f317aff7fc97
Cr-Commit-Position: refs/heads/master@{#419700}