Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.cpp

Issue 2350063002: Replace FilterData::filter with lastEffect (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.cpp
index 6c229e85adf28f0bce67c463eff7b1d808e22c2b..5df6f2f88666b4bcdab8faa584be7fa9ec053a78 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.cpp
@@ -23,20 +23,22 @@
#include "core/layout/svg/LayoutSVGResourceFilter.h"
+#include "core/svg/SVGFilterElement.h"
#include "core/svg/SVGFilterPrimitiveStandardAttributes.h"
+#include "core/svg/graphics/filters/SVGFilterBuilder.h"
namespace blink {
DEFINE_TRACE(FilterData)
{
- visitor->trace(filter);
+ visitor->trace(lastEffect);
visitor->trace(nodeMap);
}
void FilterData::dispose()
{
nodeMap = nullptr;
- filter = nullptr;
+ lastEffect = nullptr;
}
LayoutSVGResourceFilter::LayoutSVGResourceFilter(SVGFilterElement* node)
@@ -98,6 +100,16 @@ FloatRect LayoutSVGResourceFilter::resourceBoundingBox(const LayoutObject* objec
return FloatRect();
}
+SVGUnitTypes::SVGUnitType LayoutSVGResourceFilter::filterUnits() const
+{
+ return toSVGFilterElement(element())->filterUnits()->currentValue()->enumValue();
+}
+
+SVGUnitTypes::SVGUnitType LayoutSVGResourceFilter::primitiveUnits() const
+{
+ return toSVGFilterElement(element())->primitiveUnits()->currentValue()->enumValue();
+}
+
void LayoutSVGResourceFilter::primitiveAttributeChanged(LayoutObject* object, const QualifiedName& attribute)
{
SVGFilterPrimitiveStandardAttributes* primitive = static_cast<SVGFilterPrimitiveStandardAttributes*>(object->node());

Powered by Google App Engine
This is Rietveld 408576698