Add ability to pick a different gamut in GPU f16 or sRGB configs

Add ability to pick a different gamut in GPU f16 or sRGB configs

For now, the only options are sRGB or WideGamutRGB

Basically, the color option to the gpu config is now of
the form: 8888|srgb[_gamut]|f16[_gamut]

color=8888 still implies legacy behavior
srgb implies 8-bit gamma-correct rendering (via sRGB format)
f16 implies 16-bit gamma-correct rendering (via F16 format)

Either of the last two options can then optionally include
a gamut specifier, either _srgb or _wide.
_srgb selects the (default) sRGB gamut
_wide selects the Adobe Wide Gamut RGB gamut, which is nice
for testing, in that it's significantly wider than sRGB,
so rendering differences are obvious.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350003003

Committed: https://skia.googlesource.com/skia/+/4562f6ecda4dd819561e3eee17defd525017b3e1

[Brian Osman, 2016-09-19 19:31:25]

Description was changed from

==========
Add ability to pick a different gamut in GPU f16 or sRGB configs

For now, the only options are sRGB or WideGamutRGB

BUG=skia:
==========

to

==========
Add ability to pick a different gamut in GPU f16 or sRGB configs

For now, the only options are sRGB or WideGamutRGB

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350003003
==========

[Brian Osman, 2016-09-19 19:33:40]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 19:33:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Brian Osman, 2016-09-19 19:38:52]

Description was changed from

==========
Add ability to pick a different gamut in GPU f16 or sRGB configs

For now, the only options are sRGB or WideGamutRGB

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350003003
==========

to

==========
Add ability to pick a different gamut in GPU f16 or sRGB configs

For now, the only options are sRGB or WideGamutRGB

Basically, the color option to the gpu config is now of
the form: 8888|srgb[_gamut]|f16[_gamut]

color=8888 still implies legacy behavior
srgb implies 8-bit gamma-correct rendering (via sRGB format)
f16 implies 16-bit gamma-correct rendering (via F16 format)

Either of the last two options can then optionally include
a gamut specifier, either _srgb or _wide.
_srgb selects the (default) sRGB gamut
_wide selects the Adobe Wide Gamut RGB gamut, which is nice
for testing, in that it's significantly wider than sRGB,
so rendering differences are obvious.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350003003
==========

[Brian Osman, 2016-09-19 19:39:18]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, msarett@google.com, mtklein@google.com, reed@google.com

[Brian Osman, 2016-09-19 19:39:19]

https://codereview.chromium.org/2350003003/diff/1/tools/flags/SkCommonFlagsCo...
File tools/flags/SkCommonFlagsConfig.cpp (right):

https://codereview.chromium.org/2350003003/diff/1/tools/flags/SkCommonFlagsCo...
tools/flags/SkCommonFlagsConfig.cpp:317: SkStrSplit(value.c_str(), "_",
&commands);
I realize this is unfortunate (introducing a new meta-option with sub-parsing).
It would clearly be better to start decoupling this (even adding a top-level
option to DM). But given the current architecture, this seemed like the easiest
approach.

[commit-bot: I haz the power, 2016-09-19 19:39:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 19:39:20]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[Brian Osman, 2016-09-19 20:05:40]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 20:05:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 20:39:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 20:39:01]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-09-19 20:53:03]

I think with a little more effort we will kill off the 'gpu' configs in favor of
being explicit about gl, gles, or vk. What do you think about adding glwide,
etc?

[Brian Osman, 2016-09-19 21:01:11]

On 2016/09/19 20:53:03, bsalomon wrote:
> I think with a little more effort we will kill off the 'gpu' configs in favor
of
> being explicit about gl, gles, or vk. What do you think about adding glwide,
> etc?

Sounds good. I'll switch over.

[Brian Osman, 2016-09-19 21:19:21]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 21:19:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Brian Osman, 2016-09-19 21:20:16]

color option parsing remains the same. Pre-defined
configs are now glwide and vkwide. I'm really tempted to
do a separate change after this to try and restore some
sanity to this code, though.

[bsalomon, 2016-09-19 21:28:12]

lgtm

On 2016/09/19 21:20:16, Brian Osman wrote:
> color option parsing remains the same. Pre-defined
> configs are now glwide and vkwide. I'm really tempted to
> do a separate change after this to try and restore some
> sanity to this code, though.

I wouldn't discourage that :)

[Brian Osman, 2016-09-19 21:33:44]

The CQ bit was unchecked by brianosman@google.com

[Brian Osman, 2016-09-19 21:33:48]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-09-19 21:33:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 21:42:06]

Description was changed from

==========
Add ability to pick a different gamut in GPU f16 or sRGB configs

For now, the only options are sRGB or WideGamutRGB

Basically, the color option to the gpu config is now of
the form: 8888|srgb[_gamut]|f16[_gamut]

color=8888 still implies legacy behavior
srgb implies 8-bit gamma-correct rendering (via sRGB format)
f16 implies 16-bit gamma-correct rendering (via F16 format)

Either of the last two options can then optionally include
a gamut specifier, either _srgb or _wide.
_srgb selects the (default) sRGB gamut
_wide selects the Adobe Wide Gamut RGB gamut, which is nice
for testing, in that it's significantly wider than sRGB,
so rendering differences are obvious.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350003003
==========

to

==========
Add ability to pick a different gamut in GPU f16 or sRGB configs

For now, the only options are sRGB or WideGamutRGB

Basically, the color option to the gpu config is now of
the form: 8888|srgb[_gamut]|f16[_gamut]

color=8888 still implies legacy behavior
srgb implies 8-bit gamma-correct rendering (via sRGB format)
f16 implies 16-bit gamma-correct rendering (via F16 format)

Either of the last two options can then optionally include
a gamut specifier, either _srgb or _wide.
_srgb selects the (default) sRGB gamut
_wide selects the Adobe Wide Gamut RGB gamut, which is nice
for testing, in that it's significantly wider than sRGB,
so rendering differences are obvious.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350003003

Committed:
https://skia.googlesource.com/skia/+/4562f6ecda4dd819561e3eee17defd525017b3e1
==========

[commit-bot: I haz the power, 2016-09-19 21:42:07]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/4562f6ecda4dd819561e3eee17defd525017b3e1