Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2350003002: Add adb support to skpbench (Closed)

Created:
4 years, 3 months ago by csmartdalton
Modified:
4 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -12 lines) Patch
A tools/skpbench/_adb.py View 1 chunk +19 lines, -0 lines 0 comments Download
A tools/skpbench/_adb_path.py View 1 chunk +33 lines, -0 lines 0 comments Download
A tools/skpbench/_os_path.py View 1 chunk +22 lines, -0 lines 0 comments Download
M tools/skpbench/skpbench.py View 6 chunks +19 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
csmartdalton
4 years, 3 months ago (2016-09-19 03:14:55 UTC) #3
bsalomon
lgtm
4 years, 3 months ago (2016-09-19 13:22:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350003002/1
4 years, 3 months ago (2016-09-19 18:23:33 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 19:04:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0262b5c1a0ab704e42d367b070a09bb83188d983

Powered by Google App Engine
This is Rietveld 408576698