Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2341823002: skpbench (Closed)

Created:
4 years, 3 months ago by csmartdalton
Modified:
4 years, 3 months ago
Reviewers:
mtklein, bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skpbench skpbench is a benchmarking suite for skps that aims to generate 100% repeatable results. The initial commit consists of three parts: skpbench A minimalist program whose sole purpose is to open an skp file, benchmark it on a single config, and exit. No tiling, looping, or other fanciness is used; it just draws the skp whole into a size- matched render target and syncs the GPU after each draw. Limiting the entire process to a single config/skp pair helps to keep the results repeatable. skpbench.py A wrapper to execute the skpbench binary with various configs and skps. It also monitors the output in order to filter out and re-run results with an unacceptable stddev. In the future this script will lock down and monitor clocks and temperatures. parseskpbench.py A utility for parsing skpbench output into a spreadsheet. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341823002 Committed: https://skia.googlesource.com/skia/+/4b5179b74c49498e5b2b7d94319476672170b61d

Patch Set 1 #

Patch Set 2 : python2 #

Patch Set 3 : skpbench #

Patch Set 4 : skpbench #

Patch Set 5 : skpbench #

Patch Set 6 : skpbench #

Patch Set 7 : skpbench #

Patch Set 8 : stddev issues as exception #

Patch Set 9 : skpbench #

Patch Set 10 : skpbench #

Patch Set 11 : skpbench #

Patch Set 12 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+740 lines, -2 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +13 lines, -0 lines 0 comments Download
M include/private/SkGpuFenceSync.h View 1 chunk +1 line, -0 lines 0 comments Download
A + tools/skpbench/__init__.py View 1 chunk +0 lines, -2 lines 0 comments Download
A tools/skpbench/_benchresult.py View 1 2 3 4 5 6 7 1 chunk +69 lines, -0 lines 0 comments Download
A tools/skpbench/parseskpbench.py View 1 2 3 4 5 9 1 chunk +155 lines, -0 lines 0 comments Download
A tools/skpbench/skpbench.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +326 lines, -0 lines 0 comments Download
A tools/skpbench/skpbench.py View 1 2 3 4 5 6 7 8 9 1 chunk +176 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
csmartdalton
4 years, 3 months ago (2016-09-14 18:00:37 UTC) #3
csmartdalton
Pylint is giving me grief. (I only uploaded this with --bypass-hooks) It looks like it's ...
4 years, 3 months ago (2016-09-15 02:11:20 UTC) #4
mtklein
On 2016/09/15 02:11:20, csmartdalton wrote: > Pylint is giving me grief. (I only uploaded this ...
4 years, 3 months ago (2016-09-15 11:23:43 UTC) #5
csmartdalton
Ok, this is back ported to python 2 and ready for review.
4 years, 3 months ago (2016-09-16 01:42:26 UTC) #7
bsalomon
lgtm
4 years, 3 months ago (2016-09-19 12:58:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341823002/200001
4 years, 3 months ago (2016-09-19 15:15:55 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-GN-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-GN-Trybot/builds/1472)
4 years, 3 months ago (2016-09-19 15:18:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341823002/220001
4 years, 3 months ago (2016-09-19 17:47:33 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 18:04:01 UTC) #19
Message was sent while issue was closed.
Committed patchset #12 (id:220001) as
https://skia.googlesource.com/skia/+/4b5179b74c49498e5b2b7d94319476672170b61d

Powered by Google App Engine
This is Rietveld 408576698