Implement exception and finished reason in RequestFinishedInfo

components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net.impl;
 
 import android.util.Log;
 
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.annotations.CalledByNative;
@@ skipping 65 matching lines @@
      */
     private final List<String> mUrlChain = new ArrayList<String>();
     private long mReceivedBytesCountFromRedirects;
 
     private final UrlRequest.Callback mCallback;
     private final String mInitialUrl;
     private final int mPriority;
     private String mInitialMethod;
     private final HeadersList mRequestHeaders = new HeadersList();
     private final Collection<Object> mRequestAnnotations;
+    @RequestFinishedInfo.FinishedReason
+    private int mFinishedReason;
+    private UrlRequestException mException;
     private final boolean mDisableCache;
     private final boolean mDisableConnectionMigration;
 
     private CronetUploadDataStream mUploadDataStream;
 
     private UrlResponseInfo mResponseInfo;
 
     /*
      * Listener callback is repeatedly invoked when each read is completed, so it
      * is cached as a member variable.
@@ skipping 347 matching lines @@
         UrlRequestException uploadError =
                 new UrlRequestException("Exception received from UploadDataProvider", e);
         Log.e(CronetUrlRequestContext.LOG_TAG, "Exception in upload method", e);
         failWithException(uploadError);
     }
 
     /**
      * Fails the request with an exception. Can be called on any thread.
      */
     private void failWithException(final UrlRequestException exception) {
+        mException = exception;
         synchronized (mUrlRequestAdapterLock) {
             if (isDoneLocked()) {
                 return;
             }
             destroyRequestAdapter(false);
         }
         Runnable task = new Runnable() {
             @Override
             public void run() {
                 try {
@@ skipping 129 matching lines @@
 
     /**
      * Called when request is completed successfully, no callbacks will be
      * called afterwards.
      *
      * @param receivedBytesCount number of bytes received.
      */
     @SuppressWarnings("unused")
     @CalledByNative
     private void onSucceeded(long receivedBytesCount) {
+        mFinishedReason = RequestFinishedInfo.SUCCEEDED;
         mResponseInfo.setReceivedBytesCount(mReceivedBytesCountFromRedirects + receivedBytesCount);
         Runnable task = new Runnable() {
             @Override
             public void run() {
                 synchronized (mUrlRequestAdapterLock) {
                     if (isDoneLocked()) {
                         return;
                     }
                     // Destroy adapter first, so request context could be shut
                     // down from the listener.
@@ skipping 15 matching lines @@
      * @param errorCode error code from {@link UrlRequestException.ERROR_LISTENER_EXCEPTION_THROWN
      *         UrlRequestException.ERROR_*}.
      * @param nativeError native net error code.
      * @param errorString textual representation of the error code.
      * @param receivedBytesCount number of bytes received.
      */
     @SuppressWarnings("unused")
     @CalledByNative
     private void onError(int errorCode, int nativeError, int nativeQuicError, String errorString,
             long receivedBytesCount) {
+        mFinishedReason = RequestFinishedInfo.FAILED;
         if (mResponseInfo != null) {
             mResponseInfo.setReceivedBytesCount(
                     mReceivedBytesCountFromRedirects + receivedBytesCount);
         }
         if (errorCode == UrlRequestException.ERROR_QUIC_PROTOCOL_FAILED) {
             failWithException(new QuicException(
                     "Exception in CronetUrlRequest: " + errorString, nativeError, nativeQuicError));
         } else {
             failWithException(new UrlRequestException(
                     "Exception in CronetUrlRequest: " + errorString, errorCode, nativeError));
         }
     }
 
     /**
      * Called when request is canceled, no callbacks will be called afterwards.
      */
     @SuppressWarnings("unused")
     @CalledByNative
     private void onCanceled() {
+        mFinishedReason = RequestFinishedInfo.CANCELED;
         Runnable task = new Runnable() {
             @Override
             public void run() {
                 try {
                     mCallback.onCanceled(CronetUrlRequest.this, mResponseInfo);
                 } catch (Exception e) {
                     Log.e(CronetUrlRequestContext.LOG_TAG, "Exception in onCanceled method", e);
                 }
             }
         };
@@ skipping 33 matching lines @@
             mMetrics = new CronetMetrics(requestStartMs, dnsStartMs, dnsEndMs, connectStartMs,
                     connectEndMs, sslStartMs, sslEndMs, sendingStartMs, sendingEndMs, pushStartMs,
                     pushEndMs, responseStartMs, responseEndMs, socketReused, sentBytesCount,
                     receivedBytesCount);
         }
         mRequestContext.reportFinished(getRequestFinishedInfo());
     }
 
     private RequestFinishedInfo getRequestFinishedInfo() {
         // TODO(mgersh): fill in real values for finishedReason and exception
-        return new RequestFinishedInfo(mInitialUrl, mRequestAnnotations, mMetrics,
-                RequestFinishedInfo.SUCCEEDED, mResponseInfo, null);
+        return new RequestFinishedInfo(mInitialUrl, mRequestAnnotations, mMetrics, mFinishedReason,
+                mResponseInfo, mException);
     }
 
     /** Enforces prohibition of direct execution. */
     void checkCallingThread() {
         if (!mAllowDirectExecutor && mRequestContext.isNetworkThread(Thread.currentThread())) {
             throw new InlineExecutionProhibitedException();
         }
     }
 
     // Native methods are implemented in cronet_url_request_adapter.cc.
@@ skipping 17 matching lines @@
     @NativeClassQualifiedName("CronetURLRequestAdapter")
     private native boolean nativeReadData(
             long nativePtr, ByteBuffer byteBuffer, int position, int capacity);
 
     @NativeClassQualifiedName("CronetURLRequestAdapter")
     private native void nativeDestroy(long nativePtr, boolean sendOnCanceled);
 
     @NativeClassQualifiedName("CronetURLRequestAdapter")
     private native void nativeGetStatus(long nativePtr, UrlRequest.StatusListener listener);
 }