|
|
Chromium Code Reviews
DescriptionRevert "Temporarily enable scroll anchoring on trunk" (r418715).
BUG=624074
Committed: https://crrev.com/20166be8458e48f27382ef6d4fd0679cfccf9361
Cr-Commit-Position: refs/heads/master@{#422202}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 20 (10 generated)
The CQ bit was checked by skobes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
skobes@chromium.org changed reviewers: + ojan@chromium.org, rbyers@chromium.org
LGTM
Did any bugs get filed? If not, we could let it sit on dev channel for a bit. On Mon, Sep 19, 2016, 9:29 AM <rbyers@chromium.org> wrote: > LGTM > > https://codereview.chromium.org/2349943002/ > -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
Did any bugs get filed? If not, we could let it sit on dev channel for a bit. On Mon, Sep 19, 2016, 9:29 AM <rbyers@chromium.org> wrote: > LGTM > > https://codereview.chromium.org/2349943002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2016/09/19 08:33:19, ojan wrote: > Did any bugs get filed? If not, we could let it sit on dev channel for a > bit. > > On Mon, Sep 19, 2016, 9:29 AM <mailto:rbyers@chromium.org> wrote: > > > LGTM > > > > https://codereview.chromium.org/2349943002/ > > > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org. I looked for bugs with keywords "scroll" "jump" "viewport" that were opened in the last 6 days, and couldn't find anything that seemed relevant to anchoring.
On 2016/09/19 14:39:10, ymalik wrote: > On 2016/09/19 08:33:19, ojan wrote: > > Did any bugs get filed? If not, we could let it sit on dev channel for a > > bit. > > > > On Mon, Sep 19, 2016, 9:29 AM <mailto:rbyers@chromium.org> wrote: > > > > > LGTM > > > > > > https://codereview.chromium.org/2349943002/ > > > > > > > -- > > You received this message because you are subscribed to the Google Groups > > "Chromium-reviews" group. > > To unsubscribe from this group and stop receiving emails from it, send an > email > > to mailto:chromium-reviews+unsubscribe@chromium.org. > > I looked for bugs with keywords "scroll" "jump" "viewport" that were opened in > the last 6 days, and couldn't find anything that seemed relevant to anchoring. So, we want to let it go to dev channel on desktop?
I'm going to land this today, since - about:flags disabling is broken (http://crbug.com/651874), - some scroll anchoring bugs came in (http://crbug.com/651020, http://crbug.com/650017), and - M55 branches next week.
Description was changed from ========== Revert "Temporarily enable scroll anchoring on trunk." BUG=624074 ========== to ========== Revert r418715 "Temporarily enable scroll anchoring on trunk." BUG=624074 ==========
Description was changed from ========== Revert r418715 "Temporarily enable scroll anchoring on trunk." BUG=624074 ========== to ========== Revert "Temporarily enable scroll anchoring on trunk" (r418715). BUG=624074 ==========
The CQ bit was checked by skobes@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Revert "Temporarily enable scroll anchoring on trunk" (r418715). BUG=624074 ========== to ========== Revert "Temporarily enable scroll anchoring on trunk" (r418715). BUG=624074 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Revert "Temporarily enable scroll anchoring on trunk" (r418715). BUG=624074 ========== to ========== Revert "Temporarily enable scroll anchoring on trunk" (r418715). BUG=624074 Committed: https://crrev.com/20166be8458e48f27382ef6d4fd0679cfccf9361 Cr-Commit-Position: refs/heads/master@{#422202} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/20166be8458e48f27382ef6d4fd0679cfccf9361 Cr-Commit-Position: refs/heads/master@{#422202} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
