Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2379053004:
Reland "Let features::kScrollAnchoring disable the Blink REF" (r422244). (Closed)
|
Created:
4 years, 2 months ago by skobes Modified:
4 years, 2 months ago Reviewers:
Avi (use Gerrit) CC:
chromium-reviews, jam, darin-cc_chromium.org, ymalik, ojan Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReland "Let features::kScrollAnchoring disable the Blink REF" (r422244).
BUG=651874
Committed: https://crrev.com/b354d35be86d02fe23cedd5c06b6c78ffab9e469
Cr-Commit-Position: refs/heads/master@{#422512}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : don't override --enable-experimental-web-platform-features #Messages
Total messages: 28 (16 generated)
The CQ bit was checked by skobes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
skobes@chromium.org changed reviewers: + avi@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by skobes@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Let features::kScrollAnchoring disable the Blink REF. BUG=651874 ========== to ========== Let features::kScrollAnchoring disable the Blink REF. BUG=651874 Committed: https://crrev.com/560680291035d12baa675c8fd9681b1c04a4b4ac Cr-Commit-Position: refs/heads/master@{#422244} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/560680291035d12baa675c8fd9681b1c04a4b4ac Cr-Commit-Position: refs/heads/master@{#422244}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2390523002/ by qyearsley@chromium.org. The reason for reverting is: Speculative revert to see if it might fix http://crrev.com/652014.
Message was sent while issue was closed.
On 2016/10/02 at 17:21:17, qyearsley wrote: > A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2390523002/ by qyearsley@chromium.org. > > The reason for reverting is: Speculative revert to see if it might fix http://crrev.com/652014. Correction to the above message: I meant crbug.com/652014. Looks like this CL changed a few baselines, and this wasn't caught because the layout tests weren't run on the CQ here. The new baselines required should be the ones in https://codereview.chromium.org/2386933002.
Message was sent while issue was closed.
Description was changed from ========== Let features::kScrollAnchoring disable the Blink REF. BUG=651874 Committed: https://crrev.com/560680291035d12baa675c8fd9681b1c04a4b4ac Cr-Commit-Position: refs/heads/master@{#422244} ========== to ========== Let features::kScrollAnchoring disable the Blink REF. BUG=651874 Committed: https://crrev.com/560680291035d12baa675c8fd9681b1c04a4b4ac Cr-Commit-Position: refs/heads/master@{#422244} ==========
@avi: PTAL I verified the tests in crbug.com/652014 pass with patch set #3.
The CQ bit was checked by skobes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Let features::kScrollAnchoring disable the Blink REF. BUG=651874 Committed: https://crrev.com/560680291035d12baa675c8fd9681b1c04a4b4ac Cr-Commit-Position: refs/heads/master@{#422244} ========== to ========== Reland "Let features::kScrollAnchoring disable the Blink REF". BUG=651874 ==========
Description was changed from ========== Reland "Let features::kScrollAnchoring disable the Blink REF". BUG=651874 ========== to ========== Reland "Let features::kScrollAnchoring disable the Blink REF" (r422244). BUG=651874 ==========
still lgtm
The CQ bit was unchecked by skobes@chromium.org
The CQ bit was checked by skobes@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Reland "Let features::kScrollAnchoring disable the Blink REF" (r422244). BUG=651874 ========== to ========== Reland "Let features::kScrollAnchoring disable the Blink REF" (r422244). BUG=651874 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Reland "Let features::kScrollAnchoring disable the Blink REF" (r422244). BUG=651874 ========== to ========== Reland "Let features::kScrollAnchoring disable the Blink REF" (r422244). BUG=651874 Committed: https://crrev.com/b354d35be86d02fe23cedd5c06b6c78ffab9e469 Cr-Commit-Position: refs/heads/master@{#422512} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/b354d35be86d02fe23cedd5c06b6c78ffab9e469 Cr-Commit-Position: refs/heads/master@{#422512} |
