AudioBuffer: remove PadSilence()

media/base/audio_buffer.h

Index: media/base/audio_buffer.h
diff --git a/media/base/audio_buffer.h b/media/base/audio_buffer.h
index e14f08222dd5a3c0aaf7eb57ea1bf95b98a03067..80f2390eccfec5fad30e11b8e4ff08fa7f8cc36f 100644
--- a/media/base/audio_buffer.h
+++ b/media/base/audio_buffer.h
@@ -94,9 +94,15 @@ class MEDIA_EXPORT AudioBuffer
                   int dest_frame_offset,
                   AudioBus* dest);
 
-  // Add |silence_frames| frames of silence to the start of the buffer. Silence
-  // padding can be removed using any of the Trim*() methods.
-  void PadStart(int silence_frames);
+  // Copy |frames_to_copy| frames into |dest|, |frames_to_copy| is the number of
+  // frames to copy. The frames are converted from their source format into
+  // interleaved int32_t.
+  void ReadFramesInterleavedS32(int frames_to_copy, int32_t* dest);

[jrummell, 2016/09/16 23:28:00]

It appears these 2 headers got added back but not the code. Should they be left
out too?

[chcunningham, 2016/09/20 00:45:56]

Nice catch. Weird that this still compiled. Removed these

+
+  // Copy |frames_to_copy| frames into |dest|, |frames_to_copy| is the number of
+  // frames to copy. The frames are converted from their source format into
+  // interleaved int16_t.
+  void ReadFramesInterleavedS16(int frames_to_copy, int16_t* dest);
 
   // Trim an AudioBuffer by removing |frames_to_trim| frames from the start.
   // Timestamp and duration are adjusted to reflect the fewer frames.
@@ -165,10 +171,6 @@ class MEDIA_EXPORT AudioBuffer
 
   virtual ~AudioBuffer();
 
-  void AllocateAndCopy(const uint8_t* const* data,
-                       int frame_count,
-                       int silence_frames);
-
   const SampleFormat sample_format_;
   const ChannelLayout channel_layout_;
   const int channel_count_;