Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/chrome_tests_unit.gypi

Issue 23498004: Remove page cyclers from chrome binary. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_tests_unit.gypi
diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi
index e0ad6fac647cd4a5c4676a53350aa92a31fc3981..9058080c3f718f9945d84e75f7942e696f616425 100644
--- a/chrome/chrome_tests_unit.gypi
+++ b/chrome/chrome_tests_unit.gypi
@@ -1028,7 +1028,6 @@
'browser/notifications/sync_notifier/sync_notifier_test_utils.cc',
'browser/notifications/sync_notifier/sync_notifier_test_utils.h',
'browser/omnibox/omnibox_field_trial_unittest.cc',
- 'browser/page_cycler/page_cycler_unittest.cc',
'browser/parsers/metadata_parser_filebase_unittest.cc',
'browser/password_manager/login_database_unittest.cc',
'browser/password_manager/native_backend_gnome_x_unittest.cc',
@@ -2353,7 +2352,7 @@
],
# TODO(mark): We really want this for all non-static library targets,
# but when we tried to pull it up to the common.gypi level, it broke
- # other things like the ui, startup, and page_cycler tests. *shrug*
+ # other things like the ui and startup tests. *shrug*
'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-ObjC']},
}],
['OS!="mac" and OS!="ios"', {
@@ -2474,7 +2473,6 @@
'browser/download/download_shelf_unittest.cc',
'browser/storage_monitor/media_storage_util_unittest.cc',
'browser/net/gaia/gaia_oauth_fetcher_unittest.cc',
- 'browser/page_cycler/page_cycler_unittest.cc',
'browser/policy/async_policy_provider_unittest.cc',
'browser/policy/cloud/cloud_external_data_manager_base_unittest.cc',
'browser/policy/cloud/cloud_external_data_store_unittest.cc',
@@ -2681,7 +2679,7 @@
['OS=="mac"', {
# TODO(mark): We really want this for all non-static library targets,
# but when we tried to pull it up to the common.gypi level, it broke
- # other things like the ui, startup, and page_cycler tests. *shrug*
+ # other things like the ui and startup tests. *shrug*
'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-ObjC']},
}],
['OS=="win"', {

Powered by Google App Engine
This is Rietveld 408576698