chrome/chrome_browser.gypi - Issue 23498004: Remove page cyclers from chrome binary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 23498004: Remove page cyclers from chrome binary. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index c2b9674aeb1f95d518e373e1e4b1fdfbdf917f93..ff7e281d0762160cd409508bcbd111e7802a724d 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1265,8 +1265,6 @@

'browser/omnibox/omnibox_field_trial.h',

'browser/omnibox/omnibox_log.cc',

'browser/omnibox/omnibox_log.h',

- 'browser/page_cycler/page_cycler.cc',

- 'browser/page_cycler/page_cycler.h',

'browser/parsers/metadata_parser.cc',

'browser/parsers/metadata_parser.h',

'browser/parsers/metadata_parser_factory.h',

@@ -2460,14 +2458,14 @@

'browser/webdata/web_data_service_win.cc',

'browser/webdata/web_intents_table.cc',

'browser/webdata/web_intents_table.h',

- # These files are needed by page_cycler.cc

+ # These files are needed by performance_monitor.cc and this dependency

+ # should be removed (crbug.com/279660)

Nico 2013/08/27 15:05:22 nit: comments are aligned in a weird way

tonyg 2013/08/27 15:26:35 Oops, fixed. Thanks for the quick review. I'll ho

'test/base/test_switches.cc',

'test/base/test_switches.h',

'test/base/chrome_process_util.cc',

'test/base/chrome_process_util.h',

'test/base/chrome_process_util_mac.cc',

- 'test/perf/perf_test.cc',

- 'test/perf/perf_test.h',

# These files are generated by GRIT.

'<(grit_out_dir)/grit/component_extension_resources_map.cc',

@@ -3042,8 +3040,6 @@

'browser/download/download_crx_util.cc',

'browser/net/gaia/gaia_oauth_fetcher.cc',

- 'browser/page_cycler/page_cycler.cc',

- 'browser/page_cycler/page_cycler.h',

'browser/policy/async_policy_loader.cc',

'browser/policy/async_policy_loader.h',

'browser/policy/async_policy_provider.cc',

« no previous file with comments | « chrome/browser/profiles/profile_impl_io_data.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »