Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2349753002: Use Chain.capture instead of runZoned (Closed)

Created:
4 years, 3 months ago by Cutch
Modified:
4 years, 3 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use Chain.capture instead of runZoned - [x] Swap all calls of runZoned to Chain.capture. Chain.capture is a wrapper around runZoned that tracks stack traces across asynchronous gaps. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/0d831bd5c851f6434f09a76e13ae3140af3ed6bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M runtime/observatory/lib/app.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/location_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 3 months ago (2016-09-16 14:39:16 UTC) #3
rmacnak
lgtm
4 years, 3 months ago (2016-09-16 16:37:43 UTC) #4
Cutch
4 years, 3 months ago (2016-09-16 16:44:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0d831bd5c851f6434f09a76e13ae3140af3ed6bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698