runtime/observatory/lib/src/app/location_manager.dart - Issue 2349753002: Use Chain.capture instead of runZoned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/app/location_manager.dart

Issue 2349753002: Use Chain.capture instead of runZoned (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/app/location_manager.dart

diff --git a/runtime/observatory/lib/src/app/location_manager.dart b/runtime/observatory/lib/src/app/location_manager.dart

index 2e7260d730b9a09d2bcfe38bad482471a564bc4e..38dd94cbfdffed22287bc8e8b60026b28216cc4d 100644

--- a/runtime/observatory/lib/src/app/location_manager.dart

+++ b/runtime/observatory/lib/src/app/location_manager.dart

@@ -90,7 +90,7 @@ class LocationManager {

/// Notify the current page that something has changed.

_visit() {

- runZoned(() => _app._visit(_uri, internalArguments), onError: (e, st) {

+ Chain.capture(() => _app._visit(_uri, internalArguments), onError: (e, st) {

if (e is IsolateNotFound) {

var newPath = ((_app.vm == null || _app.vm.isDisconnected)

? '/vm-connect'