cc: Remove things from OutputSurface and CompositorFrameSink.

cc: Remove things from OutputSurface and CompositorFrameSink.

After forking OutputSurface, there are a lot of things on both
OutputSurface and CompositorFrameSink that only belong on one or the
other. This patch removes such things from each of them.

Next up: Make OutputSurface::BindToClient not failable. Start
renaming SwapBuffers and friends for CompositorFrameSink.

TBR=dtrainor
R=boliu, dtrainor@chromium.org, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/e41d978ab1257aca41bfe38eb9c766b7cdb3ff3c
Cr-Commit-Position: refs/heads/master@{#419548}

[danakj, 2016-09-17 01:07:03]

Description was changed from

==========
cc: Remove things from OutputSurface and CompositorFrameSink.

After forking OutputSurface, there are a lot of things on both
OutputSurface and CompositorFrameSink that only belong on one or the
other. This patch removes such things from each of them.

R=boliu, dtrainor@chromium.org, enne
BUG=606056
==========

to

==========
cc: Remove things from OutputSurface and CompositorFrameSink.

After forking OutputSurface, there are a lot of things on both
OutputSurface and CompositorFrameSink that only belong on one or the
other. This patch removes such things from each of them.

R=boliu, dtrainor@chromium.org, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-17 01:07:07]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 01:07:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-17 01:07:28]

Description was changed from

==========
cc: Remove things from OutputSurface and CompositorFrameSink.

After forking OutputSurface, there are a lot of things on both
OutputSurface and CompositorFrameSink that only belong on one or the
other. This patch removes such things from each of them.

R=boliu, dtrainor@chromium.org, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove things from OutputSurface and CompositorFrameSink.

After forking OutputSurface, there are a lot of things on both
OutputSurface and CompositorFrameSink that only belong on one or the
other. This patch removes such things from each of them.

R=boliu, dtrainor@chromium.org, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-17 01:15:34]

Description was changed from

==========
cc: Remove things from OutputSurface and CompositorFrameSink.

After forking OutputSurface, there are a lot of things on both
OutputSurface and CompositorFrameSink that only belong on one or the
other. This patch removes such things from each of them.

R=boliu, dtrainor@chromium.org, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove things from OutputSurface and CompositorFrameSink.

After forking OutputSurface, there are a lot of things on both
OutputSurface and CompositorFrameSink that only belong on one or the
other. This patch removes such things from each of them.

Next up: Make OutputSurface::BindToClient not failable. Start
renaming SwapBuffers and friends for CompositorFrameSink.

R=boliu, dtrainor@chromium.org, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-17 01:20:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 01:20:13]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-09-17 01:28:38]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 01:29:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-17 01:29:37]

https://codereview.chromium.org/2349743004/diff/20001/cc/output/compositor_fr...
File cc/output/compositor_frame_sink.h (right):

https://codereview.chromium.org/2349743004/diff/20001/cc/output/compositor_fr...
cc/output/compositor_frame_sink.h:56: bool adjust_deadline_for_parent = true;
So ok the story with this one is I left it as true everywhere because it was:
- true in DirectCFS (desktop, android)
- false in SynchronousCFS (webview)
- true in TestCFS (unit tests, layout tests)

I left that alone for now.  I was thinking of making it false everywhere except
unit tests but I don't mean to change behaviour in such a large CL.

In LTHI it will guess the parent draw time if this is true now (since
settings_.use_external_begin_frame_source is always false now because we're
using compositor_frame_sink_begin_frame_source instead, which is really the same
thing as far as that code is concerned but ya that's another issue).

[danakj, 2016-09-17 01:31:28]

danakj@chromium.org changed reviewers:
+ sky@chromium.org

[danakj, 2016-09-17 01:31:29]

enne: pls review cc/ ui/ and c/b/compositor/
bo: pls review android things
dtrainor: pls review blimp things
sky: pls review service things

I'm happy to TBR @ people once enne reviews since I'm just deleting dead stuff
also.

[commit-bot: I haz the power, 2016-09-17 02:47:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 02:47:49]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sky, 2016-09-18 16:09:02]

service 'things' eh? :) LGTM

[boliu, 2016-09-19 16:36:32]

lgtm, woot!

[enne (OOO), 2016-09-19 17:34:04]

https://codereview.chromium.org/2349743004/diff/40001/cc/test/fake_compositor...
File cc/test/fake_compositor_frame_sink_client.h (right):

https://codereview.chromium.org/2349743004/diff/40001/cc/test/fake_compositor...
cc/test/fake_compositor_frame_sink_client.h:23: // void SetNeedsRedrawRect(const
gfx::Rect& damage_rect) override {}
<_<

https://codereview.chromium.org/2349743004/diff/40001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/2349743004/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl_unittest.cc:8679: EXPECT_EQ(3,
set_needs_redraw_count);
Why does this change?

[danakj, 2016-09-19 18:48:56]

https://codereview.chromium.org/2349743004/diff/40001/cc/test/fake_compositor...
File cc/test/fake_compositor_frame_sink_client.h (right):

https://codereview.chromium.org/2349743004/diff/40001/cc/test/fake_compositor...
cc/test/fake_compositor_frame_sink_client.h:23: // void SetNeedsRedrawRect(const
gfx::Rect& damage_rect) override {}
On 2016/09/19 17:34:03, enne wrote:
> <_<

Done.

https://codereview.chromium.org/2349743004/diff/40001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/2349743004/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl_unittest.cc:8679: EXPECT_EQ(3,
set_needs_redraw_count);
On 2016/09/19 17:34:03, enne wrote:
> Why does this change?

Cuz I call SetNeedsRedraw() here which draws. Before it called
SetNeedsRedrawRect with an empty rect which just early-outs. But that function
is gone.

[enne (OOO), 2016-09-19 18:50:36]

lgtm

https://codereview.chromium.org/2349743004/diff/40001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/2349743004/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl_unittest.cc:8679: EXPECT_EQ(3,
set_needs_redraw_count);
On 2016/09/19 at 18:48:55, danakj wrote:
> On 2016/09/19 17:34:03, enne wrote:
> > Why does this change?
> 
> Cuz I call SetNeedsRedraw() here which draws. Before it called
SetNeedsRedrawRect with an empty rect which just early-outs. But that function
is gone.

Thanks! I missed the early out part of that.

[danakj, 2016-09-19 18:50:56]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 18:51:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-19 18:52:29]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-09-19 18:52:30]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org,
sky@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2349743004/#ps60001
(title: "delete-stuff-cfs: comment-and-rebase")

[commit-bot: I haz the power, 2016-09-19 18:52:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-19 18:53:33]

Description was changed from

==========
cc: Remove things from OutputSurface and CompositorFrameSink.

After forking OutputSurface, there are a lot of things on both
OutputSurface and CompositorFrameSink that only belong on one or the
other. This patch removes such things from each of them.

Next up: Make OutputSurface::BindToClient not failable. Start
renaming SwapBuffers and friends for CompositorFrameSink.

R=boliu, dtrainor@chromium.org, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove things from OutputSurface and CompositorFrameSink.

After forking OutputSurface, there are a lot of things on both
OutputSurface and CompositorFrameSink that only belong on one or the
other. This patch removes such things from each of them.

Next up: Make OutputSurface::BindToClient not failable. Start
renaming SwapBuffers and friends for CompositorFrameSink.

TBR=dtrainor
R=boliu, dtrainor@chromium.org, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-19 18:53:42]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-09-19 18:54:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 21:09:52]

Description was changed from

==========
cc: Remove things from OutputSurface and CompositorFrameSink.

After forking OutputSurface, there are a lot of things on both
OutputSurface and CompositorFrameSink that only belong on one or the
other. This patch removes such things from each of them.

Next up: Make OutputSurface::BindToClient not failable. Start
renaming SwapBuffers and friends for CompositorFrameSink.

TBR=dtrainor
R=boliu, dtrainor@chromium.org, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove things from OutputSurface and CompositorFrameSink.

After forking OutputSurface, there are a lot of things on both
OutputSurface and CompositorFrameSink that only belong on one or the
other. This patch removes such things from each of them.

Next up: Make OutputSurface::BindToClient not failable. Start
renaming SwapBuffers and friends for CompositorFrameSink.

TBR=dtrainor
R=boliu, dtrainor@chromium.org, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-19 21:09:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-19 21:13:33]

Description was changed from

==========
cc: Remove things from OutputSurface and CompositorFrameSink.

After forking OutputSurface, there are a lot of things on both
OutputSurface and CompositorFrameSink that only belong on one or the
other. This patch removes such things from each of them.

Next up: Make OutputSurface::BindToClient not failable. Start
renaming SwapBuffers and friends for CompositorFrameSink.

TBR=dtrainor
R=boliu, dtrainor@chromium.org, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove things from OutputSurface and CompositorFrameSink.

After forking OutputSurface, there are a lot of things on both
OutputSurface and CompositorFrameSink that only belong on one or the
other. This patch removes such things from each of them.

Next up: Make OutputSurface::BindToClient not failable. Start
renaming SwapBuffers and friends for CompositorFrameSink.

TBR=dtrainor
R=boliu, dtrainor@chromium.org, enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/e41d978ab1257aca41bfe38eb9c766b7cdb3ff3c
Cr-Commit-Position: refs/heads/master@{#419548}
==========

[commit-bot: I haz the power, 2016-09-19 21:13:35]

Patchset 4 (id:??) landed as
https://crrev.com/e41d978ab1257aca41bfe38eb9c766b7cdb3ff3c
Cr-Commit-Position: refs/heads/master@{#419548}