Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2349633002: Move PseudoId parsing out of CSSComputedStyleDeclaration constructor into CSSSelector (Closed)

Created:
4 years, 3 months ago by meade_UTC10
Modified:
4 years, 3 months ago
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PseudoId parsing out of CSSComputedStyleDeclaration constructor into CSSSelector This will allow us to use it for the computed CSSStylePropertyMap for CSS Typed OM. BUG=545318 Committed: https://crrev.com/8e05df27a3915a2dee9faee5008e4cf51da67bd3 Cr-Commit-Position: refs/heads/master@{#419950}

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelector.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelector.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
meade_UTC10
4 years, 3 months ago (2016-09-16 05:24:25 UTC) #5
rjwright1
On 2016/09/16 05:24:25, Eddy wrote: lgtm!
4 years, 3 months ago (2016-09-16 05:28:09 UTC) #6
rune
lgtm
4 years, 3 months ago (2016-09-16 08:01:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349633002/20001
4 years, 3 months ago (2016-09-21 00:33:03 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-21 02:20:25 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 02:22:51 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e05df27a3915a2dee9faee5008e4cf51da67bd3
Cr-Commit-Position: refs/heads/master@{#419950}

Powered by Google App Engine
This is Rietveld 408576698