third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp - Issue 2349633002: Move PseudoId parsing out of CSSComputedStyleDeclaration constructor into CSSSelector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

Issue 2349633002: Move PseudoId parsing out of CSSComputedStyleDeclaration constructor into CSSSelector (Closed)

Patch Set: Fix typo Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

index bf38771975fcc1cd488da0f6d0ac001747ac343f..e4c9d61380096377090f26ee58b11e68fd596645 100644

--- a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

+++ b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

@@ -355,11 +355,9 @@ static const Vector<CSSPropertyID>& computableProperties()

CSSComputedStyleDeclaration::CSSComputedStyleDeclaration(Node* n, bool allowVisitedStyle, const String& pseudoElementName)

: m_node(n)

+ , m_pseudoElementSpecifier(CSSSelector::parsePseudoId(pseudoElementName))

, m_allowVisitedStyle(allowVisitedStyle)

{

- unsigned nameWithoutColonsStart = pseudoElementName[0] == ':' ? (pseudoElementName[1] == ':' ? 2 : 1) : 0;

- m_pseudoElementSpecifier = CSSSelector::pseudoId(CSSSelector::parsePseudoType(

- AtomicString(pseudoElementName.substring(nameWithoutColonsStart)), false));

}

CSSComputedStyleDeclaration::~CSSComputedStyleDeclaration()

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSSelector.h » ('j') | no next file with comments »