Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2349623003: Add a Browser Task Scheduler Chrome Internals Page (Closed)

Created:
4 years, 3 months ago by robliao
Modified:
4 years, 2 months ago
Reviewers:
xiyuan, gab, Nico, fdoray, Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a Browser Task Scheduler Chrome Internals Page This adds a simple status to show if the task scheduler is instantiated or not to set up the infrastructure. More information will be added in subsequent CLs. BUG=553459 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/71aed696616be775fe6d0c47d0ba67a2bfc5cef9 Cr-Commit-Position: refs/heads/master@{#421255}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Mac/Linux Fix + String Change #

Total comments: 14

Patch Set 3 : CR Feedback #

Total comments: 10

Patch Set 4 : CR Feedback #

Patch Set 5 : Move Files into task_scheduler_internals Directory and Add OWNERS #

Total comments: 2

Patch Set 6 : Remvoe allowexternalscript #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -0 lines) Patch
M chrome/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/BUILD.gn View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/browser/resources/task_scheduler_internals/OWNERS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/task_scheduler_internals/index.html View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/browser/resources/task_scheduler_internals/resources.grd View 1 2 3 4 5 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/task_scheduler_internals/OWNERS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/ui/webui/task_scheduler_internals/task_scheduler_internals_ui.h View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/task_scheduler_internals/task_scheduler_internals_ui.cc View 1 2 3 4 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/task_scheduler_internals/task_scheduler_internals_ui_browsertest.cc View 1 2 3 4 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/chrome_paks.gni View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 73 (46 generated)
robliao
4 years, 3 months ago (2016-09-16 21:16:37 UTC) #4
gab
lgtm in general but I'm not at all a resources/ + webui/ reviewer :-) https://codereview.chromium.org/2349623003/diff/1/chrome/browser/ui/webui/task_scheduler_internals_ui.cc ...
4 years, 3 months ago (2016-09-19 20:46:19 UTC) #8
robliao
xiyuan@chromium.org: Please review changes in chrome/browser/resources/* chrome/browser/ui/webui/* thakis@chromium.org: Please review changes in chrome/BUILD.gn tools/gritsettings/resource_ids Thanks! ...
4 years, 3 months ago (2016-09-21 00:31:54 UTC) #10
xiyuan
https://codereview.chromium.org/2349623003/diff/20001/chrome/browser/resources/task_scheduler_internals/index.html File chrome/browser/resources/task_scheduler_internals/index.html (right): https://codereview.chromium.org/2349623003/diff/20001/chrome/browser/resources/task_scheduler_internals/index.html#newcode2 chrome/browser/resources/task_scheduler_internals/index.html:2: <html> Do we need to worry about i18n ? ...
4 years, 3 months ago (2016-09-21 05:01:39 UTC) #15
fdoray
non-expert lgtm
4 years, 3 months ago (2016-09-21 18:00:33 UTC) #16
robliao
Thanks for the comments! https://codereview.chromium.org/2349623003/diff/20001/chrome/browser/resources/task_scheduler_internals/index.html File chrome/browser/resources/task_scheduler_internals/index.html (right): https://codereview.chromium.org/2349623003/diff/20001/chrome/browser/resources/task_scheduler_internals/index.html#newcode2 chrome/browser/resources/task_scheduler_internals/index.html:2: <html> On 2016/09/21 05:01:38, xiyuan ...
4 years, 3 months ago (2016-09-21 22:32:03 UTC) #17
xiyuan
lgtm
4 years, 3 months ago (2016-09-21 22:48:45 UTC) #20
robliao
On 2016/09/21 22:48:45, xiyuan wrote: > lgtm Ping for thakis. Thanks!
4 years, 3 months ago (2016-09-22 17:31:08 UTC) #23
Nico
lgtm, but I'm adding a webui/OWNER too
4 years, 3 months ago (2016-09-23 17:48:57 UTC) #31
Dan Beam
this is way too much code can't you just respond with a plain-text nextwork resource ...
4 years, 3 months ago (2016-09-23 17:59:03 UTC) #32
robliao
On 2016/09/23 17:59:03, Dan Beam wrote: > this is way too much code > > ...
4 years, 3 months ago (2016-09-23 18:00:45 UTC) #33
robliao
On 2016/09/23 17:48:57, Nico wrote: > lgtm, but I'm adding a webui/OWNER too For the ...
4 years, 3 months ago (2016-09-23 18:03:55 UTC) #36
Dan Beam
https://codereview.chromium.org/2349623003/diff/40001/chrome/browser/resources/task_scheduler_internals/index.html File chrome/browser/resources/task_scheduler_internals/index.html (right): https://codereview.chromium.org/2349623003/diff/40001/chrome/browser/resources/task_scheduler_internals/index.html#newcode7 chrome/browser/resources/task_scheduler_internals/index.html:7: --> you don't need this (very few other html ...
4 years, 3 months ago (2016-09-23 18:09:00 UTC) #37
Dan Beam
can we also put this into a sub directory or add per-file owners? many of ...
4 years, 3 months ago (2016-09-23 18:14:25 UTC) #38
robliao
Patch 4 covers the feedback. Thanks for the review! > can we also put this ...
4 years, 3 months ago (2016-09-23 21:45:10 UTC) #41
robliao
Ping for dbeam. Thanks.
4 years, 2 months ago (2016-09-26 18:01:11 UTC) #51
Dan Beam
lgtm https://codereview.chromium.org/2349623003/diff/80001/chrome/browser/resources/task_scheduler_internals/resources.grd File chrome/browser/resources/task_scheduler_internals/resources.grd (right): https://codereview.chromium.org/2349623003/diff/80001/chrome/browser/resources/task_scheduler_internals/resources.grd#newcode17 chrome/browser/resources/task_scheduler_internals/resources.grd:17: allowexternalscript="false" nit: i think this option only has ...
4 years, 2 months ago (2016-09-26 18:10:35 UTC) #53
robliao
https://codereview.chromium.org/2349623003/diff/80001/chrome/browser/resources/task_scheduler_internals/resources.grd File chrome/browser/resources/task_scheduler_internals/resources.grd (right): https://codereview.chromium.org/2349623003/diff/80001/chrome/browser/resources/task_scheduler_internals/resources.grd#newcode17 chrome/browser/resources/task_scheduler_internals/resources.grd:17: allowexternalscript="false" On 2016/09/26 18:10:34, Dan Beam wrote: > nit: ...
4 years, 2 months ago (2016-09-26 18:15:48 UTC) #54
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349623003/100001
4 years, 2 months ago (2016-09-26 18:16:33 UTC) #57
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/286359)
4 years, 2 months ago (2016-09-26 20:20:01 UTC) #59
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349623003/100001
4 years, 2 months ago (2016-09-26 20:22:11 UTC) #61
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/148326)
4 years, 2 months ago (2016-09-26 22:40:48 UTC) #63
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349623003/100001
4 years, 2 months ago (2016-09-26 22:43:29 UTC) #65
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/148525)
4 years, 2 months ago (2016-09-27 02:00:32 UTC) #67
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349623003/100001
4 years, 2 months ago (2016-09-27 17:02:30 UTC) #69
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 2 months ago (2016-09-27 17:40:47 UTC) #71
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 17:44:33 UTC) #73
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/71aed696616be775fe6d0c47d0ba67a2bfc5cef9
Cr-Commit-Position: refs/heads/master@{#421255}

Powered by Google App Engine
This is Rietveld 408576698